Fixes, improvements + Auto Window handling #2648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MyDrift-user
changed the title
MyDrift-user
changed the title
- added $args param for args that get passed to winutil - improved starting new Shell logic
MyDrift-user
changed the title
- removed old logic - fixed command to run in new shell - replaced $args with $arg
- move log start to after admin elevation - fix color of border on fixed tweaks button.
- use theme value instead of custom value
- set cutom microwin checkbox margin due to cut off content
CodingWonders
approved these changes
Aug 30, 2024
- replace strange collumndefinition to fix bugs, make sense and look better
og-mrk
reviewed
Aug 30, 2024
og-mrk
reviewed
Aug 30, 2024
og-mrk
reviewed
Aug 30, 2024
| $powershellcmd = if (Get-Command pwsh -ErrorAction SilentlyContinue) { "pwsh" } else { "powershell" } | ||
| $processCmd = if (Get-Command wt.exe -ErrorAction SilentlyContinue) { "wt.exe" } else { $powershellcmd } | ||
|
|
||
| Start-Process $processCmd -ArgumentList "$powershellcmd -NoProfile -Command $script" |
There was a problem hiding this comment.
... so if you don't have wt.exe installed, it'll launch powershell (or pwsh).. and then that powershell will launch another powershell, which'll run the script?
This's way too nested, and I do agree that most devs working on this project work in Windows 11 (not 10), but I think there's room for improvements.
There was a problem hiding this comment.
I totally agree there, Chris liked using wt.exe if possible so I implemented it. Sure needs some work bc wt.exe and powershell work diffrently. I think that may be a task for another PR tho..
og-mrk
reviewed
Aug 30, 2024
ChrisTitusTech
approved these changes
Aug 30, 2024
ruxunderscore
added a commit
to ruxunderscore/winutil
that referenced
this pull request
Oct 11, 2024
- Rollback changes from ChrisTitusTech#2648 - Create Variable for script location. - irm -> Invoke-RestMethod, for Powershell standard coding practices. - iex -> Invoke-Expression, for Powershell standard coding practices.
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Refractor Fixes Correct Window handling
Type of Change
Description
Add auto size handling of window, but with a max size cap, that will be removed once the window is shown so the user can resize the window as wished. Window should on run never be to big for the screen again.
change fontsize back to something lower to display content of winutil correctly, it was only changed bc og-mrk's branch was a bit older, meaning it had older values.
Added Custom Margin for Microwin Checkboxes because their label cuts off if used withnormal margin.
fixed layouting of fixed tweaks buttons to not cut off in the center and truly work on a mobile resolution
add args param for compile script, which passes args to winutil
improve run action in compile script
move logs to after admin elevation
fix left nav side being to big and cutting stuff off:
closes [Feature] Add ability to provide arguments to winutil after Compile & Run #2625
Testing
Checklist