Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EdgeRemoval optimization and refactor #2530

Merged
merged 4 commits into from
Aug 7, 2024

Conversation

psyirius
Copy link
Contributor

@psyirius psyirius commented Aug 6, 2024

Title

Optimization and Cleanup of the script that i submitted on stream today

Type of Change

  • Refactoring

Additional Information

  • me: same person from the stream chat today: Techie Jack (aka: Psyirius)
  • EdgeRemover script cleanup, optimization and refactor!
  • Removed the old standalone script (edgeremoval.ps1) and the copy of RegionPolicy json!
  • No more RegionPolicy shenanegans!
  • Removes EdgeWebView (most programs install it anyway, if it's needed and not found)
  • Removes EdgeUpdate (the updater)
  • Fixed name in the tweak credits...

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no errors/warnings/merge conflicts.

- me: same person from the stream chat today: Techie Jack (aka: Psyirius)

- cleaner script
- removes EdgeWebView
  - most programs install it, if it's needed and not found
- removes EdgeUpdate (the updater)
- and Preprocessing refactor
@psyirius psyirius changed the title EdgeRemoval cleanup (from stream today: Techie Jack) EdgeRemoval optimization and refactor (from stream today: Techie Jack) Aug 6, 2024
Copy link
Owner

@ChrisTitusTech ChrisTitusTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good made a small change, but thanks for the contribution @psyirius

@ChrisTitusTech ChrisTitusTech merged commit 138c5de into ChrisTitusTech:main Aug 7, 2024
1 check passed
@psyirius psyirius deleted the er-fix branch August 7, 2024 21:40
@psyirius psyirius changed the title EdgeRemoval optimization and refactor (from stream today: Techie Jack) EdgeRemoval optimization and refactor Aug 7, 2024
@ChrisTitusTech ChrisTitusTech added the skip-changelog Skip Change Logs label Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog Skip Change Logs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants