Hotfix/view valid answer #38
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merging updates
Signed-off-by: A. Prooks <[email protected]>
Signed-off-by: A. Prooks <[email protected]>
| @@ -70,7 +70,7 @@ exports.getById = function(id) { | |||
| return problem.questionsRef.indexOf(question.id) > -1; | |||
| }) | |||
| .map(function(question) { | |||
| return _.pick(question, ['id', 'title', 'options', 'answered', 'isCorrect']); | |||
| return _.pick(question, ['id', 'title', 'options', 'answered', 'isCorrect','validAnswer']); | |||
There was a problem hiding this comment.
Somehow we need to get the valid answer so that an admin can edit it... however should we filter it out if the request is from a student? or should we let the student cheat?
|
With current API design we have to choose one of the following, if we want a proper problems edititing:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
valid answer should be returned by Api , because it is needed at editProblem form