Skip to content

Commit

Permalink
Merge PR cosmos#79: ICS 25: Handler interface
Browse files Browse the repository at this point in the history
  • Loading branch information
cwgoes authored Jun 9, 2019
1 parent a7eaffa commit 90bcc82
Show file tree
Hide file tree
Showing 13 changed files with 461 additions and 20 deletions.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
SUBDIRS := spec/ics-3-connection-semantics spec/ics-4-channel-and-packet-semantics
SUBDIRS := spec/ics-003-connection-semantics spec/ics-004-channel-and-packet-semantics
TOPTARGETS := all clean

$(TOPTARGETS): $(SUBDIRS)
Expand Down
4 changes: 2 additions & 2 deletions deps.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion scripts/check_links.py
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
sys.exit(1)
titles = [int(x[0]) for x in title_regex.findall(data)]
for num in titles:
matched = [f for f in files if f[7:7+4+len(str(num))+1] == 'ics-' + str(num) + '-']
matched = [f for f in files if f[7:7+4+len(str(num).zfill(3))+1] == 'ics-' + str(num).zfill(3) + '-']
if len(matched) > 0:
print('Expected "ICS {}" to link to {} but not found!'.format(num, matched[0]))
sys.exit(1)
2 changes: 1 addition & 1 deletion spec/ics-002-consensus-verification/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ as long as associated light client algorithms fulfilling the requirements are pr
verified state roots which can be utilized by downstream logic to verify subcomponents
of state at particular heights.

* `createClient`, `queryClient`, `updateClient`, `freezeClient`, and `deleteClient` function signatures are as defined in ICS 25.
* `createClient`, `queryClient`, `updateClient`, `freezeClient`, and `deleteClient` function signatures are as defined in [ICS 25](../ics-025-handler-interface).
The function implementations are defined in this standard.

### Desired Properties
Expand Down
8 changes: 8 additions & 0 deletions spec/ics-003-connection-semantics/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,16 @@ ics: 3
title: Connection Semantics
stage: draft
category: ibc-core
<<<<<<< HEAD
requires: 23, 24
required-by: 25
=======
requires: 2, 23, 24
<<<<<<< HEAD:spec/ics-3-connection-semantics/README.md
>>>>>>> master
=======
required-by: 4
>>>>>>> master:spec/ics-003-connection-semantics/README.md
author: Christopher Goes <[email protected]>, Juwoon Yun <[email protected]>
created: 2019-03-07
modified: 2019-05-17
Expand Down
2 changes: 1 addition & 1 deletion spec/ics-003-connection-semantics/state.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
10 changes: 0 additions & 10 deletions spec/ics-004-channel-and-packet-semantics/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -361,16 +361,6 @@ function chanCloseInit(
The `chanCloseTry` function is called by the handshake-accepting module
to acknowledge the channel close request and continue the closing process.

```typescript
interface ChanCloseTry {
connectionIdentifier: Identifier
channelIdentifier: Identifier
timeoutHeight: uint64
nextTimeoutHeight: uint64
proofInit: CommitmentProof
}
```

```typescript
function chanCloseTry(
connectionIdentifier: Identifier, channelIdentifier: Identifier,
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion spec/ics-004-channel-and-packet-semantics/dataflow.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading

0 comments on commit 90bcc82

Please sign in to comment.