Select first available channel when accepting ownership change #3382
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a draft as the implementation it introduces must be discussed.
Per request in #2240, I've slightly changed the select form in
my-accept-ownership.component.html
so that the first element ofvideoChannels
is automatically selected. This, however, occurs regardless of the amount of channels an account has. This is the behavior I want to discuss with you. Should it remain as is, or should I refactor this PR to follow more closely the request of #2240?Secondly, I had to change the
disable
condition of the "Accept" button. While the aforementioned change somehow worked fine if an account had multiple channels, the "Accept" button would remain greyed out if the account only had one channel.Related issues
Resolves #2240
Has this been tested?
I don't know if tests should be added to the tests suite and/or modified.
Manual testing showed that the changes introduced by this PR are working as expected on my end.
Screenshots
These screenshots are taken just right after clicking on the "checkmark" button to open the popup.
When the account only has one channel
When the account has 2 or more channels