default youtube-dl to use ipv4

[markvdb]

Description

It seems YouTube does not like ipv6 clients (HTTP Error 429). This extra option works around that.

Has this been tested?

• 👍 yes, I added tests to the test suite
• 👍 yes, light tests as follows are enough
• 💭 no, because this PR is a draft and still needs work
• 🙅 no, because they aren't needed
• 🙋 no, because I need help

[Findus23]

Keep in mind that I think youtube also returns 429 if your IP is rate limited so it might be an issue independent of ipv6.

[markvdb]

There was zero traffic between this machine and yt in the two weeks before I noticed ytdl failing. I'm a great ipv6 proponent. I saw lots of references though to yt ipv6 support being rather tricky. I verified --force-ipv4 solved the issue for me. Whatever YouTube decides internally about accepting requests or not will always remain a black box. It doesn't help that the ytdl repo is still down... Op zo 15 nov. 2020 om 20:48 schreef Lukas Winkler <[email protected]

…

: Keep in mind that I think youtube also returns 429 if your IP is rate limited so it might be an issue independent of ipv6. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#3311 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAF6ECG4WJJZSEAV2HKLLTDSQAWBHANCNFSM4TWMBN5A> .

-- Mark Van den Borre Hogestraat 16 3000 Leuven, België +32 486 961726

[Chocobozzz]

Please add a configuration key forceIPV4 in config: https://github.com/Chocobozzz/PeerTube/blob/develop/config/default.yaml#L289 (that defaults to true)

[rigelk]

@markvdb I’m not sure you understand what "adding a configuration key" involves. Yes, adding it to the config/default.yaml is a good start but nothing is taking it into account in the rest of the code. Please see how the CONFIG object resulting from importing the config/production.yaml in which you also need to add the configuration key is used: https://github.com/Chocobozzz/PeerTube/blob/develop/server/helpers/youtube-dl.ts#L9

[markvdb]

I was more than aware this was not all that was needed yet, but had little clue to be able to look any further, so thank you for your helpful suggestion.

Up until now, I've only grepped through the PeerTube source code and read things.

I'm very much attracted by the PeerTube concept, but not very much by the wobbliness of the node ecosystem in general. I need to overcome some mental hurdles for that :-)

[markvdb]

@rigelk @Chocobozzz I guess this is more or less what you meant.

I read https://docs.joinpeertube.org/#/contribute-getting-started?id=develop only after I finishing this. I hope I'm not spoiling too much your time by submitting this tiny pull request. Let's hope it doesn't contain too many silly syntax errors...