Add possibility to share origin URL to video if it's not local #3201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chocobozzz
reviewed
Oct 23, 2020
| <div *ngIf="!isLocalVideo() && !isVideoInEmbedTab()" class="form-group"> | ||
| <my-peertube-checkbox | ||
| inputName="originUrl" [(ngModel)]="customizations.originUrl" | ||
| i18n-labelText labelText="Origin URL" |
There was a problem hiding this comment.
Maybe Use origin instance URL instead?
There was a problem hiding this comment.
Good point, I changed it.
It's very difficult to share the original URL for a video when you watch it on your own instance while it's not from it but from a different instance. Right now when you use the share UI you only can share a link so a person can watch it on your own instance, this patch adds a checkbox to the share UI to share the origin URL instead if needed.
|
Thanks @jeena |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's very difficult to share the original URL for a video when you watch it on your
own instance while it's not from it but from a different instance. Right now when
you use the share UI you only can share a link so a person can watch it on your
own instance, this patch adds a checkbox to the share UI to share the origin URL
instead if needed.