-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fcbk open-graph and twitter-card metas for accounts, video-channels, playlists urls #2996
Add fcbk open-graph and twitter-card metas for accounts, video-channels, playlists urls #2996
Conversation
c4dea59
to
9a6e49d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add tests for accounts, channels and playlists meta tags? https://github.com/Chocobozzz/PeerTube/blob/develop/server/tests/client.ts
Maybe you could also refactor addAccountOrChannelOpenGraphAndMetaTags
, addVideoPlaylistOpenGraphAndMetaTags
and addVideoOpenGraphAndOEmbedTags
methods that share some code
9cfca56
to
ae174d8
Compare
Please fix lint tests and https://travis-ci.com/github/Chocobozzz/PeerTube/jobs/365185689 test |
I'll try but the tests still not work in local, maybe I should open an issue, it's a serious problem for contributions... |
Yes please |
I"ve added some tests, but I still have this problem with local tests #3022
I've refactored all these methods. |
Thanks |
Fixes: #2989
Tests :