Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide generic channel display name and avatar on watch view #2988

Merged
merged 3 commits into from
Jul 24, 2020

Conversation

kimsible
Copy link
Contributor

@kimsible kimsible commented Jul 20, 2020

First stab at : #2987
fixes #2953

  • No avatar channel and generic display name (Main username channel) channel :
    the big avatar and account name redirect to the account page
    no-avatar-and-channel

  • Generic display name (Main username channel) and a channel avatar is uploaded
    the small avatar is the channel avatar and redirect to the channel page
    no-channel-avatar-not-null

  • Display name channel and avatar channel customized
    back to regular display
    n-avatar-and-channel

@kimsible kimsible marked this pull request as draft July 20, 2020 16:15
@kimsible kimsible marked this pull request as ready for review July 20, 2020 16:27
@rigelk rigelk added the UI non-trivial UI changes, that might need discussion label Jul 20, 2020
@Chocobozzz
Copy link
Owner

Nice job 👍 Just one little thing and we can merge this

@kimsible
Copy link
Contributor Author

Nice job +1 Just one little thing and we can merge this

Thanks for the review =). I forgot the search result, should we also adapt display for this view ?

image

@kimsible kimsible force-pushed the feat/hide-generic-channel branch from 6000457 to a1857a5 Compare July 23, 2020 19:40
@Chocobozzz
Copy link
Owner

I forgot the search result, should we also adapt display for this view ?

I don't think so, because we are explicitly searching for channels. To not confuse users, let's keep the current display in the search page

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Waiting for changes UI non-trivial UI changes, that might need discussion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default ABC channel / Main ABC channel
3 participants