Remove uneccessary details to link titles #2879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rigelk
added
Component: Accessibility
UI
|
Thanks! Is there a reason you don't put an uppercase at the beginning of the title? (plugin homepage (new window) VS Plugin homepage (new window)) |
|
Hello ! No I was searching for "Go to" and delete it. I can add uppercase :) |
Pandoraaa
force-pushed
the
accessible-links
branch
from
a926087
to
d5af62e
Compare
rigelk
approved these changes
Jun 17, 2020
|
Thanks @Pandoraaa |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will improve a11y with short link title when needed.
Link title should not have verb like "go to" for screen readers.
More improving should be done with all the target="_blank" attribute on another PR with either (new window) in title/text or adding a new window icon with css :)