Skip to content
Main Branch Coverage

Reworked Promise Caching for Batching. (#6919) #161

Sign in to view logs

Reworked Promise Caching for Batching. (#6919)

Reworked Promise Caching for Batching. (#6919) #161

GitHub Actions / Qodana for .NET completed Feb 19, 2024 in 0s

5491 new problems found by Qodana for .NET

Qodana for .NET

5491 new problems were found

Inspection name Severity Problems
Use preferred style for trailing comma before new line in multiline lists 🔴 Failure 6
Namespace does not correspond to file location 🔶 Warning 1403
Auto-property accessor is never used (non-private accessibility) 🔶 Warning 1009
Redundant type declaration body 🔶 Warning 348
Unused parameter (private accessibility) 🔶 Warning 238
Member hides static member from outer class 🔶 Warning 197
Possible unassigned object created by 'new' expression 🔶 Warning 192
Possible 'null' assignment to non-nullable entity 🔶 Warning 189
Redundant argument with default value 🔶 Warning 148
Virtual member call in constructor 🔶 Warning 129
Variable can be declared as non-nullable 🔶 Warning 124
Return type of a function can be non-nullable 🔶 Warning 104
Redundant nullable warning suppression expression 🔶 Warning 99
Parameter is only used for precondition check (private accessibility) 🔶 Warning 96
Non-accessed positional property (non-private accessibility) 🔶 Warning 84
Unused local variable 🔶 Warning 83
Get-only auto-property is never assigned 🔶 Warning 76
Collection is never updated (private accessibility) 🔶 Warning 70
Use preferred namespace body style 🔶 Warning 68
Redundant nullable directive 🔶 Warning 67
Assignment is not used 🔶 Warning 64
Variable in local function hides variable from outer scope 🔶 Warning 60
Redundant cast 🔶 Warning 50
Redundant using directive 🔶 Warning 50
Type member is never used (private accessibility) 🔶 Warning 47
Potentially misleading parameter name in lambda or local function 🔶 Warning 43
Explicit delegate creation expression is redundant 🔶 Warning 27
Expression is always 'true' or 'false' according to nullable reference types' annotations 🔶 Warning 22
Conditional access qualifier expression is known to be null or not null 🔶 Warning 21
Element is localizable 🔶 Warning 20
Non-accessed local variable 🔶 Warning 17
Possible 'System.NullReferenceException' 🔶 Warning 17
Conditional access qualifier expression is not null according to nullable reference types' annotations 🔶 Warning 16
Do not use object initializer for 'using' variable 🔶 Warning 16
Collection is never updated (non-private accessibility) 🔶 Warning 15
Auto-property accessor is never used (private accessibility) 🔶 Warning 15
Expression is always 'null' 🔶 Warning 14
Non-accessed field (private accessibility) 🔶 Warning 14
Redundant type arguments of method 🔶 Warning 14
Access to disposed captured variable 🔶 Warning 13
Redundant member initializer 🔶 Warning 12
Empty constructor 🔶 Warning 11
Possible performance issues caused by unlimited string length 🔶 Warning 11
Unused type parameter 🔶 Warning 11
Redundant name qualifier 🔶 Warning 10
Duplicate resource name 🔶 Warning 9
Empty statement is redundant 🔶 Warning 9
Method return value is never used (private accessibility) 🔶 Warning 9
Use null check pattern instead of a type check succeeding on any not-null value 🔶 Warning 8
Redundant explicit type in array creation 🔶 Warning 8
Unused nullable directive 🔶 Warning 8
'??' condition is never null according to nullable reference types' annotations 🔶 Warning 7
Return value of a method annotated with [MustDisposeResource] is never disposed 🔶 Warning 6
Possible multiple enumeration 🔶 Warning 6
Redundant 'Attribute' suffix 🔶 Warning 6
Usage of <inheritdoc /> is invalid 🔶 Warning 5
Redundant class or interface specification in base types list 🔶 Warning 5
Inconsistent synchronization on field 🔶 Warning 4
Non-accessed positional property (private accessibility) 🔶 Warning 4
Static field or auto-property in generic type 🔶 Warning 4
Collection content is never queried (non-private accessibility) 🔶 Warning 3
Disposal of a variable already captured by the 'using' statement 🔶 Warning 3
Heuristically unreachable code 🔶 Warning 3
Member initialized value ignored 🔶 Warning 3
Cannot resolve symbol in text argument 🔶 Warning 3
Private field can be converted into local variable 🔶 Warning 3
Return value of pure method is not used 🔶 Warning 3
Access to modified captured variable 🔶 Warning 2
Expression is always 'true' or always 'false' 🔶 Warning 2
Explicit argument passed to parameter with caller info attribute 🔶 Warning 2
Invalid XML documentation comment 🔶 Warning 2
Redundant nullable attribute 🔶 Warning 2
Return of a task produced by 'using'-captured object 🔶 Warning 2
Type is never used (private accessibility) 🔶 Warning 2
Co-variant array conversion 🔶 Warning 1
Empty general catch clause 🔶 Warning 1
Entity is only used to capture its name (private accessibility) 🔶 Warning 1
Underlying type of enum is 'int' 🔶 Warning 1
Similar expressions comparison 🔶 Warning 1
Non-nullable or required member is not initialized at constructor exit 🔶 Warning 1
The source expression never matches the provided pattern 🔶 Warning 1
Redundant anonymous type property explicit name 🔶 Warning 1
Redundant base constructor call 🔶 Warning 1
Redundant empty object or collection initializer 🔶 Warning 1
Redundant control flow jump statement 🔶 Warning 1
Redundant arithmetic overflow checking context 🔶 Warning 1
Redundant 'object.ToString()' call 🔶 Warning 1
Redundant 'WithCancellation()' invocation 🔶 Warning 1
Suspicious parameter name in ArgumentNullException 🔶 Warning 1
Redundant 'base.' qualifier ◽️ Notice 3

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

Details

This result was published with Qodana GitHub Action

Annotations

Check warning on line 826 in HotChocolate/AspNetCore/test/AspNetCore.Tests/Subscriptions/GraphQLOverWebSocket/WebSocketProtocolTests.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Access to disposed captured variable 

Captured variable is disposed in the outer scope

Check warning on line 41 in HotChocolate/Data/test/Data.EntityFramework.Tests/EntityFrameworkResolverCompilerIntegrationTests.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Access to disposed captured variable 

Captured variable is disposed in the outer scope

Check warning on line 57 in StrawberryShake/Client/test/Transport.WebSocket.Tests/Protocols/GraphQLWebSocket/GraphQLWebSocketWriterExtensionTests.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Access to disposed captured variable 

Captured variable is disposed in the outer scope

Check warning on line 87 in HotChocolate/Data/test/Data.EntityFramework.Tests/EntityFrameworkResolverCompilerIntegrationTests.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Access to disposed captured variable 

Captured variable is disposed in the outer scope

Check warning on line 41 in StrawberryShake/Client/test/Transport.WebSocket.Tests/Protocols/GraphQLWebSocket/GraphQLWebSocketWriterExtensionTests.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Access to disposed captured variable 

Captured variable is disposed in the outer scope

Check warning on line 44 in StrawberryShake/Client/test/Transport.WebSocket.Tests/Messaging/SynchronizedMessageWriterTests.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Access to disposed captured variable 

Captured variable is disposed in the outer scope

Check warning on line 222 in HotChocolate/AspNetCore/test/Transport.Sockets.Client.Tests/GraphQLOverWebSocket/WebSocketClientProtocolTests.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Access to disposed captured variable 

Captured variable is disposed in the outer scope

Check warning on line 65 in HotChocolate/Data/test/Data.EntityFramework.Tests/EntityFrameworkResolverCompilerIntegrationTests.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Access to disposed captured variable 

Captured variable is disposed in the outer scope

Check warning on line 22 in StrawberryShake/Tooling/src/dotnet-graphql/Program.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Access to disposed captured variable 

Captured variable is disposed in the outer scope

Check warning on line 184 in HotChocolate/Core/test/Types.Tests/SchemaSerializerTests.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Access to disposed captured variable 

Captured variable is disposed in the outer scope

Check warning on line 63 in HotChocolate/AspNetCore/src/AspNetCore/Subscriptions/WebSocketSession.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Access to disposed captured variable 

Captured variable is disposed in the outer scope

Check warning on line 85 in StrawberryShake/Client/test/Transport.WebSocket.Tests/Protocols/GraphQLWebSocket/GraphQLWebSocketWriterExtensionTests.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Access to disposed captured variable 

Captured variable is disposed in the outer scope

Check warning on line 66 in HotChocolate/Core/test/Subscriptions.InMemory.Tests/InMemoryIntegrationTests.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Access to disposed captured variable 

Captured variable is disposed in the outer scope

Check warning on line 28 in HotChocolate/Diagnostics/test/Diagnostics.Tests/ActivityTestHelper.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Access to modified captured variable 

Captured variable is modified in the outer scope

Check warning on line 88 in StrawberryShake/CodeGeneration/src/CodeGeneration.CSharp/Generators/DataTypeGenerator.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Access to modified captured variable 

Captured variable is modified in the outer scope

Check warning on line 127 in HotChocolate/Caching/test/Caching.Tests/CacheControlDirectiveTypeTests.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Potentially misleading parameter name in lambda or local function 

The '_' name is typically reserved for parameters without usages

Check warning on line 44 in HotChocolate/Caching/test/Caching.Tests/CacheControlTypeInterceptorTests.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Potentially misleading parameter name in lambda or local function 

The '_' name is typically reserved for parameters without usages

Check warning on line 226 in HotChocolate/Caching/test/Caching.Tests/CacheControlDirectiveTypeTests.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Potentially misleading parameter name in lambda or local function 

The '_' name is typically reserved for parameters without usages

Check warning on line 74 in HotChocolate/Core/test/Types.Tests/Types/DescriptionTests.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Potentially misleading parameter name in lambda or local function 

The '_' name is typically reserved for parameters without usages

Check warning on line 195 in HotChocolate/Caching/test/Caching.Tests/CacheControlDirectiveTypeTests.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Potentially misleading parameter name in lambda or local function 

The '_' name is typically reserved for parameters without usages

Check warning on line 506 in HotChocolate/Core/test/Types.Tests/Types/ObjectTypeTests.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Potentially misleading parameter name in lambda or local function 

The '_' name is typically reserved for parameters without usages

Check warning on line 209 in HotChocolate/Core/test/Types.Tests/Types/Directives/CostDirectiveTypeTests.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Potentially misleading parameter name in lambda or local function 

The '_' name is typically reserved for parameters without usages

Check warning on line 531 in HotChocolate/Core/test/Types.Tests/Types/ObjectTypeTests.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Potentially misleading parameter name in lambda or local function 

The '_' name is typically reserved for parameters without usages

Check warning on line 130 in HotChocolate/Core/test/Types.Tests/Types/DescriptionTests.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Potentially misleading parameter name in lambda or local function 

The '_' name is typically reserved for parameters without usages

Check warning on line 45 in HotChocolate/Core/test/Types.Tests/Types/DescriptionTests.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Potentially misleading parameter name in lambda or local function 

The '_' name is typically reserved for parameters without usages
View more details on GitHub Actions