Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete methods: RemovePath and RemoveLocations #7860

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

JesseXia
Copy link

Summary

According to graphql spec -

The path and the error is always required in the field execution context.

The existing methods are now obsolete.

Closes #7828

@JesseXia JesseXia marked this pull request as ready for review December 23, 2024 00:30
Copy link

codecov bot commented Dec 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.33%. Comparing base (d1e6ac3) to head (97fd408).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7860      +/-   ##
==========================================
+ Coverage   74.32%   74.33%   +0.01%     
==========================================
  Files        2880     2880              
  Lines      150189   150183       -6     
  Branches    17468    17465       -3     
==========================================
+ Hits       111629   111644      +15     
+ Misses      32745    32727      -18     
+ Partials     5815     5812       -3     
Flag Coverage Δ
unittests 74.33% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove RemoveLocation and RemovePath methods from error and error builder.
1 participant