[Fusion] Improve Inlining Rewriter #7838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelstaib
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7838 +/- ##
=======================================
Coverage 74.38% 74.38%
=======================================
Files 2876 2876
Lines 150071 150071
Branches 17450 17450
=======================================
+ Hits 111625 111637 +12
+ Misses 32630 32617 -13
- Partials 5816 5817 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
michaelstaib
commented
Dec 17, 2024
...te/Fusion-vnext/test/Fusion.Execution.Tests/Planning/InlineFragmentOperationRewriterTests.cs
Show resolved
Hide resolved
| public FragmentDefinitionNode GetFragmentDefinition(string name) | ||
| => fragments[name]; | ||
|
|
||
| public void AddField(FieldNode field) | ||
| { | ||
| if (!Fields.TryGetValue(field.Name.Value, out var fields)) |
There was a problem hiding this comment.
Should be alias or name.
michaelstaib
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.