Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Middleware Issues #782

Merged
merged 13 commits into from
May 23, 2019
Merged

Fixed Middleware Issues #782

merged 13 commits into from
May 23, 2019

Conversation

michaelstaib
Copy link
Member

@michaelstaib michaelstaib commented May 22, 2019 •
edited
Loading

  • In classic we now manually create a service scope so that the DataLoader and other scoped services work correctly.
  • Add error codes to authentication errors.
  • AuthorizeDirective does not deserialize roles property correctly if it is passed as a single string

Fixes #771
Fixes #770
Fixes #624

@michaelstaib
Copy link
Member Author

We should add Use and Use(Factory> to the descriptors instead of extension methods.

@michaelstaib michaelstaib self-assigned this May 22, 2019
@michaelstaib michaelstaib added the 🎨 refactoring This issue is about doing refactoring work, like cleaning up the code making existing code better. label May 22, 2019
@michaelstaib michaelstaib added this to the 9.0.0 milestone May 22, 2019
@michaelstaib michaelstaib merged commit 04e7d1a into master May 23, 2019
@michaelstaib michaelstaib deleted the auth_error_codes branch May 23, 2019 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@michaelstaib michaelstaib

Labels
🎨 refactoring This issue is about doing refactoring work, like cleaning up the code making existing code better.
Projects
None yet
Milestone
9.0.0
1 participant
@michaelstaib