Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added '@' prefix when exporting directives in Apollo. #7812

Merged

Conversation

danielreynolds1
Copy link
Collaborator

Added '@' prefix when exporting directives using a type rather than a name.
Modified tests to ensure both use cases are snapshotted.

(Partially) Closes #7799

@danielreynolds1 danielreynolds1 added the Area: Apollo Federation Issue is related to Apollo Federation label Dec 7, 2024
Copy link

codecov bot commented Dec 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.34%. Comparing base (4cbe8b9) to head (36f7844).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7812   +/-   ##
=======================================
  Coverage   74.33%   74.34%           
=======================================
  Files        2871     2871           
  Lines      149797   149797           
  Branches    17416    17416           
=======================================
+ Hits       111346   111360   +14     
+ Misses      32652    32635   -17     
- Partials     5799     5802    +3     
Flag Coverage Δ
unittests 74.34% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@michaelstaib michaelstaib merged commit 3b6e888 into ChilliCream:main Dec 11, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Apollo Federation Issue is related to Apollo Federation 🌶️ hot chocolate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ExportDirective with type argument fails to prepend @ to directive name
2 participants