Added ability to mark requests as warmup #7798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
📚 documentation
tobias-tengler
force-pushed
the
tte/implement-warmup
branch
from
1f25ea7 to
5d59732
Compare
tobias-tengler
force-pushed
the
tte/implement-warmup
branch
from
5d59732 to
e548aac
Compare
|
This one is looking good. Will merge it tomorrow. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7798 +/- ##
==========================================
- Coverage 74.34% 74.33% -0.01%
==========================================
Files 2867 2870 +3
Lines 149872 149897 +25
Branches 17414 17416 +2
==========================================
+ Hits 111416 111426 +10
- Misses 32653 32666 +13
- Partials 5803 5805 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
michaelstaib
approved these changes
Dec 3, 2024
michaelstaib
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hot Chocolate has long had
InitializeOnStartupas a mechanism to optimize the performance of initial operations.It also already has the ability to execute warmup tasks. If you want to initialize caches at startup, by for example performing a dry run of your most important persisted operations, you were kind of out of luck, since there was no easy and builtin way to skip the actual execution of those warmup requests.
This PR adds the ability to mark requests as warmup, so they skip the execution step and bypass things like persisted operations. I've also documented the entire feature in more detail.