Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved LocalDate/LocalTime to HotChocolate.Types and added LocalDateTime #7749

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

glen-84
Copy link
Collaborator

@glen-84 glen-84 commented Nov 21, 2024

Summary of the changes (Less than 80 chars)

  • Moved LocalDate/LocalTime to HotChocolate.Types and added LocalDateTime.

Closes #6420


LocalDate and LocalTime scalars moved

LocalDate and LocalTime have been moved from HotChocolate.Types.Scalars to HotChocolate.Types, and are therefore available without installing the additional package.

DateOnly and TimeOnly binding change

  • DateOnly is now bound to LocalDateType instead of DateType.
  • TimeOnly is now bound to LocalTimeType instead of TimeSpanType.

@glen-84 glen-84 added the 💥 breaking-changes This PR contains breaking changes. label Nov 21, 2024
@glen-84 glen-84 added this to the HC-15.0.0 milestone Nov 21, 2024
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.33%. Comparing base (b521e35) to head (00cdb2e).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7749      +/-   ##
==========================================
- Coverage   74.34%   74.33%   -0.01%     
==========================================
  Files        2860     2862       +2     
  Lines      149841   149886      +45     
  Branches    17411    17417       +6     
==========================================
+ Hits       111395   111423      +28     
- Misses      32647    32664      +17     
  Partials     5799     5799              
Flag Coverage Δ
unittests 74.33% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@michaelstaib michaelstaib added the 📢 announce Consider announcing on Slack. label Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📢 announce Consider announcing on Slack. 💥 breaking-changes This PR contains breaking changes. 🌶️ hot chocolate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TimeOnly is expecting a TimeSpan Type
2 participants