-
-
Notifications
You must be signed in to change notification settings - Fork 749
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support nodes field for automatic mocking #7728
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7728 +/- ##
==========================================
+ Coverage 74.00% 74.02% +0.02%
==========================================
Files 2918 2918
Lines 151252 151252
Branches 17576 17576
==========================================
+ Hits 111936 111967 +31
+ Misses 33464 33434 -30
+ Partials 5852 5851 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
tobias-tengler
force-pushed
the
tte/support-nodes-for-automatic-mocking
branch
from
November 17, 2024 10:04
2ce12e2
to
12190e4
Compare
michaelstaib
pushed a commit
that referenced
this pull request
Nov 19, 2024
tobias-tengler
added
the
🍒 cherry-pick
Consider cherry-picking these changes into the previous major version.
label
Nov 27, 2024
tobias-tengler
added a commit
that referenced
this pull request
Nov 28, 2024
michaelstaib
pushed a commit
that referenced
this pull request
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
🍒 cherry-pick
Consider cherry-picking these changes into the previous major version.
🌶️ hot chocolate
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the
nodes
field didn't properly return items with theids
that were specified.This PR fixes this and also ensures that
id
values being generated are unique within a request.