Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support nodes field for automatic mocking #7728

Merged
merged 5 commits into from
Nov 17, 2024

Conversation

tobias-tengler
Copy link
Collaborator

@tobias-tengler tobias-tengler commented Nov 16, 2024

Previously the nodes field didn't properly return items with the ids that were specified.

This PR fixes this and also ensures that id values being generated are unique within a request.

Copy link

codecov bot commented Nov 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.02%. Comparing base (8004643) to head (4345e0c).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7728      +/-   ##
==========================================
+ Coverage   74.00%   74.02%   +0.02%     
==========================================
  Files        2918     2918              
  Lines      151252   151252              
  Branches    17576    17576              
==========================================
+ Hits       111936   111967      +31     
+ Misses      33464    33434      -30     
+ Partials     5852     5851       -1     
Flag Coverage Δ
unittests 74.02% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tobias-tengler tobias-tengler force-pushed the tte/support-nodes-for-automatic-mocking branch from 2ce12e2 to 12190e4 Compare November 17, 2024 10:04
@michaelstaib michaelstaib merged commit 8868901 into main Nov 17, 2024
5 checks passed
@michaelstaib michaelstaib deleted the tte/support-nodes-for-automatic-mocking branch November 17, 2024 21:38
@michaelstaib michaelstaib removed the 👓 ready-for-review The PR is ready for review. label Nov 27, 2024
@michaelstaib michaelstaib added this to the HC-15.0.0 milestone Nov 27, 2024
@tobias-tengler tobias-tengler added the 🍒 cherry-pick Consider cherry-picking these changes into the previous major version. label Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍒 cherry-pick Consider cherry-picking these changes into the previous major version. 🌶️ hot chocolate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants