Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed the runtime type for LocalDateType, LocalTimeType, and DateType #7717

Merged
merged 4 commits into from
Nov 17, 2024

Conversation

glen-84
Copy link
Collaborator

@glen-84 glen-84 commented Nov 14, 2024

Summary of the changes (Less than 80 chars)

  • Changed the runtime type for LocalDateType, LocalTimeType, and DateType.

Closes #7718

Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.02%. Comparing base (a18706c) to head (4d5af6a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7717   +/-   ##
=======================================
  Coverage   74.02%   74.02%           
=======================================
  Files        2918     2918           
  Lines      151252   151251    -1     
  Branches    17576    17570    -6     
=======================================
+ Hits       111959   111967    +8     
+ Misses      33440    33436    -4     
+ Partials     5853     5848    -5     
Flag Coverage Δ
unittests 74.02% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@glen-84 glen-84 added the 💥 breaking-changes This PR contains breaking changes. label Nov 14, 2024
@glen-84 glen-84 added this to the HC-15.0.0 milestone Nov 14, 2024
@glen-84 glen-84 marked this pull request as draft November 15, 2024 08:24
@glen-84 glen-84 marked this pull request as ready for review November 15, 2024 09:00
@michaelstaib michaelstaib merged commit f086132 into main Nov 17, 2024
5 checks passed
@michaelstaib michaelstaib deleted the gai/date-time-runtime-type branch November 17, 2024 21:42
@glen-84 glen-84 restored the gai/date-time-runtime-type branch November 18, 2024 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💥 breaking-changes This PR contains breaking changes. 🌶️ hot chocolate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change runtime type for LocalDateType, LocalTimeType, and DateType
2 participants