Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include net9.0 tools in StrawberryShake package #7710

Conversation

TylerSiegrist
Copy link
Contributor

Summary of the changes (Less than 80 chars)

  • Include net9.0 tools in StrawberryShake package

Closes #7659

@CLAassistant
Copy link

CLAassistant commented Nov 12, 2024

CLA assistant check
All committers have signed the CLA.

@cmeeren
Copy link
Contributor

cmeeren commented Nov 18, 2024

Would be great to get this merged and released! Also being blocked by this.

@Sander0542
Copy link

I would love to see this feature released, so I can upgrade my application to .NET 9

@Cheesebaron
Copy link
Contributor

Yeah even the 15.0.0-p.14 tool goes nuts like this:

dotnet "/Users/tomaszcielecki/.nuget/packages/strawberryshake.maui/15.0.0-p.14/build/../tools/net9/dotnet-graphql.dll" generate "/Users/tomaszcielecki/git/ApiRange/TrackMan.Api.Gql" -o "/Users/tomaszcielecki/git/ApiRange/TrackMan.Api.Gql/obj/Debug/net9.0/berry" -n TrackMan.Api.Gql -a md5
8.0.403 [/usr/local/share/dotnet/sdk]
9.0.100-rc.2.24474.11 [/usr/local/share/dotnet/sdk]
9.0.100 [/usr/local/share/dotnet/sdk]
The command could not be loaded, possibly because:
  * You intended to execute a .NET application:
      The application '/Users/tomaszcielecki/.nuget/packages/strawberryshake.maui/15.0.0-p.14/build/../tools/net9/dotnet-graphql.dll' does not exist.
  * You intended to execute a .NET SDK command:
      A compatible .NET SDK was not found.

Requested SDK version: 6.0.100
global.json file: /Users/tomaszcielecki/.nuget/packages/strawberryshake.maui/15.0.0-p.14/build/global.json

Would be really nice to get this one out or at least allow roll-foward

@glen-84
Copy link
Collaborator

glen-84 commented Nov 19, 2024

We need to add .NET 9 as a target first, and that is currently blocked by JasperFx/marten#3558.

@Sander0542
Copy link

Sander0542 commented Nov 19, 2024

We need to add .NET 9 as a target first, and that is currently blocked by JasperFx/marten#3558.

This has been merged and released in https://github.com/JasperFx/marten/releases/tag/V7.33.0

https://www.nuget.org/packages/Marten/7.33.0

@loekensgard
Copy link

Also being blocked by this, would like to see it released 😄

@Huzeyfe20
Copy link

Would like to see it released, blocked by this :)

@MoienTajik
Copy link
Contributor

Hey @michaelstaib, could you please take a look at this one? It’s breaking our pipelines.

@glen-84
Copy link
Collaborator

glen-84 commented Nov 20, 2024

#7741

@glen-84 glen-84 added the 🍒 cherry-pick Consider cherry-picking these changes into the previous major version. label Nov 20, 2024
@michaelstaib michaelstaib merged commit 3681f75 into ChilliCream:main Nov 20, 2024
100 checks passed
@glen-84 glen-84 added this to the HC-14.2.0 milestone Nov 21, 2024
@loekensgard
Copy link

I tried to use the new package version 14.2.0-p.2, but I keep encountering an error that states .NET 9 is missing. Could I be overlooking something?

image

@michaelstaib
Copy link
Member

Yes .. the pr is missing the whole logic on selecting the framework

@glen-84
Copy link
Collaborator

glen-84 commented Nov 27, 2024

@loekensgard Can you try 14.2.0-p.4?

@loekensgard
Copy link

@glen-84, I am getting the same error as before:

image

@glen-84
Copy link
Collaborator

glen-84 commented Nov 27, 2024

Apologies, I was misled by #6395, thinking that that was the only change necessary. I've opened #7772.

@JaggerJo

This comment was marked as off-topic.

@Malgefor
Copy link

When can we expect this to be released?

@Cheesebaron
Copy link
Contributor

Cheesebaron commented Nov 29, 2024

I guess the same issue is there with Barista/ChilliCream.Nitro.CLI too

@glen-84
Copy link
Collaborator

glen-84 commented Nov 29, 2024

Please try 14.2.0-p.7.

@loekensgard
Copy link

It works 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍒 cherry-pick Consider cherry-picking these changes into the previous major version. 🌶️ strawberry shake
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include net9.0 tools in StrawberryShake package