Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added "AddDataLoader<TService, TImplementation>" overload that takes a factory #7674

Merged

Conversation

danielreynolds1
Copy link
Collaborator

@danielreynolds1 danielreynolds1 commented Nov 2, 2024

Add "AddDataLoader<TService, TImplementation>" overload that takes a factory.

Summary of the changes:

  • A new overload that allows a factory to be provided for the implementation.
  • Previously, this was only available when using the single generic option.

@glen-84 glen-84 changed the title Add "AddDataLoader<TService, TImplementation" overload that takes a factory. Add "AddDataLoader<TService, TImplementation>" overload that takes a factory. Nov 5, 2024
@glen-84 glen-84 changed the title Add "AddDataLoader<TService, TImplementation>" overload that takes a factory. Add "AddDataLoader<TService, TImplementation>" overload that takes a factory Nov 5, 2024
@michaelstaib michaelstaib changed the title Add "AddDataLoader<TService, TImplementation>" overload that takes a factory Added "AddDataLoader<TService, TImplementation>" overload that takes a factory Nov 6, 2024
@michaelstaib michaelstaib added this to the HC-14.2.0 milestone Nov 6, 2024
Copy link

codecov bot commented Nov 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.94%. Comparing base (b271436) to head (ba977f7).
Report is 31 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7674   +/-   ##
=======================================
  Coverage   73.93%   73.94%           
=======================================
  Files        2917     2917           
  Lines      151088   151095    +7     
  Branches    17554    17556    +2     
=======================================
+ Hits       111704   111720   +16     
+ Misses      33530    33522    -8     
+ Partials     5854     5853    -1     
Flag Coverage Δ
unittests 73.94% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@michaelstaib michaelstaib merged commit 2cae6c3 into ChilliCream:main Nov 7, 2024
103 checks passed
@glen-84 glen-84 added the 🍒 cherry-pick Consider cherry-picking these changes into the previous major version. label Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍒 cherry-pick Consider cherry-picking these changes into the previous major version. 🌶️ green donut
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants