Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fusion] Fixed composition of spec directives #7643

Merged
merged 5 commits into from
Oct 31, 2024

Conversation

tobias-tengler
Copy link
Collaborator

One of our subgraphs (for whatever reason) specifies the @specifiedBy spec directive in its schema. This leads to issues, since Skimmed would create a dummy directive definition (without args and locations) for schemas where the spec directive is not defined, vs the directive definition will be parsed from the schema. This leads to composition errors, since the shape of the directives doesn't match.

This PR updates Skimmed to ignore spec directives and instead register the complete spec directive (with all arguments, locations, etc.) if it's encountered in a schema.

Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.79%. Comparing base (9e86b1b) to head (9a8f551).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7643   +/-   ##
=======================================
  Coverage   73.79%   73.79%           
=======================================
  Files        2922     2918    -4     
  Lines      150895   150918   +23     
  Branches    17549    17554    +5     
=======================================
+ Hits       111349   111368   +19     
- Misses      33724    33729    +5     
+ Partials     5822     5821    -1     
Flag Coverage Δ
unittests 73.79% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@michaelstaib michaelstaib changed the title [Fusion] Fix composition of spec directives [Fusion] Fixed composition of spec directives Oct 31, 2024
@michaelstaib michaelstaib merged commit 1ab2fa3 into main Oct 31, 2024
5 checks passed
@michaelstaib michaelstaib deleted the tte/fix-specifiedby-composition branch October 31, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants