[Fusion] Fixed composition of spec directives #7643
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of our subgraphs (for whatever reason) specifies the
@specifiedBy
spec directive in its schema. This leads to issues, since Skimmed would create a dummy directive definition (without args and locations) for schemas where the spec directive is not defined, vs the directive definition will be parsed from the schema. This leads to composition errors, since the shape of the directives doesn't match.This PR updates Skimmed to ignore spec directives and instead register the complete spec directive (with all arguments, locations, etc.) if it's encountered in a schema.