Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated target frameworks #7471

Merged
merged 7 commits into from
Sep 23, 2024
Merged

Updated target frameworks #7471

merged 7 commits into from
Sep 23, 2024

Conversation

glen-84
Copy link
Collaborator

@glen-84 glen-84 commented Sep 19, 2024

Summary of the changes (Less than 80 chars)

  • Updated target frameworks.

Notes:

  • I've removed the non-generic version of OrderedDictionary to align with .NET 9.
  • I needed to install Basic.Reference.Assemblies.Net90, which requires Microsoft.CodeAnalysis.Common (>= 4.9.2), so I've updated Microsoft.CodeAnalysis.CSharp and Microsoft.CodeAnalysis.CSharp.Workspaces to version 4.9.2, and Microsoft.CodeAnalysis.Analyzers to version 3.3.4.
    • New analyzer warnings:
      • RS1031 - Fixed.
      • RS2008 - Added to NoWarn for now – do you want to enable analyzer release tracking?
    • Related, I think, there were also quite a few formatting changes to the generated code for Strawberry Shake.
  • I've removed most of the .vscode directories, since they are inconsistently added, reference various different old frameworks, etc.

Questions:

  • ✅ There is one warning related to AOT in HotChocolate.Utilities, could you please assist?
    • HotChocolate/Utilities/src/Utilities/DependencyInjection/ServiceFactory.cs, L45.
    • Applying a simple fix causes another warning.
  • 🚫 Since the Azure in-process model is being deprecated, should we:
    1. Update the in-process template to .NET 8 anyway. OR
    2. Remove the in-process template.
      • Rename HotChocolate.Template.AzureFunctions.Isolated to HotChocolate.Template.AzureFunctions?
      • function -> azure-function?
  • ✅ There are a bunch of warnings (local only) since NuGet auditing is now applied to transitive dependencies.
  • ✅ Can I remove the Spatial.Demo project? It's outdated, and after applying some fixes it still seems broken. We could probably fix it, but I think it's the only demo project in the solution, so it seems out of place.
  • 🚫 What is the status of templates/StarWars?
    • It doesn’t seem to be “modernized”.
    • Do you want to keep it?

Copy link

codecov bot commented Sep 19, 2024

Codecov Report

Attention: Patch coverage is 89.28571% with 3 lines in your changes missing coverage. Please review.

Project coverage is 77.85%. Comparing base (1af69c6) to head (a82be0f).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...rc/Abstractions/Execution/OperationResultHelper.cs 0.00% 2 Missing ⚠️
...rization.Opa/Request/DefaultQueryRequestFactory.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7471      +/-   ##
==========================================
- Coverage   77.86%   77.85%   -0.01%     
==========================================
  Files        2827     2825       -2     
  Lines      142072   141927     -145     
==========================================
- Hits       110630   110503     -127     
+ Misses      31442    31424      -18     
Flag Coverage Δ
unittests 77.85% <89.28%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@glen-84 glen-84 marked this pull request as ready for review September 23, 2024 08:35
@michaelstaib michaelstaib merged commit 879287c into main Sep 23, 2024
4 checks passed
@michaelstaib michaelstaib deleted the gai/update-target-frameworks branch September 23, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants