Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visit ObjectValue nodes when validating unused variables #746

Merged
merged 6 commits into from
May 15, 2019

Conversation

nigel-sampson
Copy link
Contributor

@nigel-sampson nigel-sampson commented May 15, 2019

Resolves an in issue where a variable used in a decomposed complex input type was not being validated as being used.

query queryWithComplexInput($name: String) {
    findDog(complex: { name: $name }) {
        name
    }
}

Fixes #745
Fixes #215

@michaelstaib
Copy link
Member

Can you also have a look at variables in lists?

@michaelstaib michaelstaib self-requested a review May 15, 2019 21:38
@michaelstaib michaelstaib added this to the 9.0.0 milestone May 15, 2019
@michaelstaib
Copy link
Member

I have updated the changlog and will merge this one as soon as the build becomes green.

@michaelstaib michaelstaib merged commit 319ac87 into ChilliCream:master May 15, 2019
@nigel-sampson nigel-sampson deleted the variable-complex-input branch May 15, 2019 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants