Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added FieldSelectionMap parser #7211

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Conversation

glen-84
Copy link
Collaborator

@glen-84 glen-84 commented Jul 1, 2024

Summary of the changes (Less than 80 chars)

  • Added FieldSelectionMap parser.

🚫 Blocked by:

Notes:

  1. I'm not sure if the FieldSelectionMapSyntaxSerializer is correct, taking over the visitation and then returning Skip.
  2. Since the parser is similar to the main GraphQL parser, it is affected by the same issue with locations (incorrect End values).
  3. The following types could potentially be shared.
    • Location (if the ISyntaxNode crefs were removed)
    • TokenInfo (if the ISyntaxNode crefs were removed)
    • ISyntaxVisitorAction
    • SyntaxVisitorActionKind
    • SyntaxVisitorActionExtensions
    • *SyntaxVisitorAction

@glen-84 glen-84 marked this pull request as draft July 1, 2024 11:09
@michaelstaib michaelstaib changed the base branch from fusion-vnext to main October 29, 2024 10:15
Copy link

codecov bot commented Dec 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.34%. Comparing base (7ecc977) to head (acf1d65).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7211      +/-   ##
==========================================
+ Coverage   74.33%   74.34%   +0.01%     
==========================================
  Files        2880     2880              
  Lines      150294   150294              
  Branches    17479    17479              
==========================================
+ Hits       111716   111732      +16     
+ Misses      32762    32744      -18     
- Partials     5816     5818       +2     
Flag Coverage Δ
unittests 74.34% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@michaelstaib michaelstaib marked this pull request as ready for review January 3, 2025 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants