Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Pure Resolver Context #7186

Merged
merged 3 commits into from
Jun 21, 2024
Merged

Conversation

michaelstaib
Copy link
Member

No description provided.

@github-actions github-actions bot added 📚 documentation This issue is about working on our documentation. 🌶️ hot chocolate labels Jun 20, 2024
Copy link

codecov bot commented Jun 20, 2024

Codecov Report

Attention: Patch coverage is 51.72414% with 42 lines in your changes missing coverage. Please review.

Project coverage is 72.03%. Comparing base (336ffcd) to head (3a84595).

Current head 3a84595 differs from pull request most recent head 14c3647

Please upload reports for the commit 14c3647 to get more accurate results.

Files Patch % Lines
...src/Execution/Processing/MiddlewareContext.Pure.cs 19.35% 25 Missing ⚠️
...s/Parameters/ArgumentParameterExpressionBuilder.cs 50.00% 3 Missing ⚠️
.../Parameters/OperationParameterExpressionBuilder.cs 33.33% 2 Missing ⚠️
...ns/Parameters/ServiceParameterExpressionBuilder.cs 0.00% 2 Missing ⚠️
...Types/Resolvers/DefaultParameterBindingResolver.cs 0.00% 1 Missing ⚠️
...ions/Parameters/FieldParameterExpressionBuilder.cs 50.00% 1 Missing ⚠️
...arameters/FieldSyntaxParameterExpressionBuilder.cs 66.66% 1 Missing ⚠️
...Parameters/IsSelectedParameterExpressionBuilder.cs 0.00% 1 Missing ⚠️
...Parameters/ObjectTypeParameterExpressionBuilder.cs 50.00% 1 Missing ⚠️
...eters/ResolverContextParameterExpressionBuilder.cs 0.00% 1 Missing ⚠️
... and 4 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7186      +/-   ##
==========================================
- Coverage   78.75%   72.03%   -6.73%     
==========================================
  Files        2373     2657     +284     
  Lines      117509   132929   +15420     
==========================================
+ Hits        92546    95751    +3205     
- Misses      24963    37178   +12215     
Flag Coverage Δ
unittests 72.03% <51.72%> (-6.73%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@michaelstaib michaelstaib merged commit 0423ade into main Jun 21, 2024
27 of 32 checks passed
@michaelstaib michaelstaib deleted the mst/remove-pure-resolver-context branch June 21, 2024 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📚 documentation This issue is about working on our documentation. 🌶️ hot chocolate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant