Gracefully handle subgraph transport errors #6968
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qodana for .NET5 new problems were found
💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at [email protected]
|
tobias-tengler
force-pushed
the
improve-fusion-transport-error-handling
branch
from
5c8b87e to
5653f05
Compare
tobias-tengler
commented
Mar 17, 2024
| @@ -100,8 +98,7 @@ public ValueTask<OperationResult> ReadAsResultAsync(CancellationToken cancellati | |||
| #endif | |||
| } | |||
|
|
|||
| // if the media type is anything else we will return a transport error. | |||
| return new ValueTask<OperationResult>(_transportError); | |||
| throw new Exception("Transport error"); | |||
There was a problem hiding this comment.
Throw a proper exception and why was the previous behavior even there?
| @@ -187,7 +184,7 @@ public IAsyncEnumerable<OperationResult> ReadAsResultStreamAsync(CancellationTok | |||
| #endif | |||
| } | |||
|
|
|||
| return SingleResult(new ValueTask<OperationResult>(_transportError)); | |||
| throw new Exception("Stream transport error"); | |||
| using var response = await _client.SendAsync(request, ct).ConfigureAwait(false); | ||
| var result = await response.ReadAsResultAsync(ct).ConfigureAwait(false); | ||
| return new GraphQLResponse(result); | ||
| } | ||
| catch | ||
| { | ||
| return _transportError; | ||
| return new GraphQLResponse(true); |
| HasError = hasError; | ||
| } | ||
|
|
||
| public bool HasError { get; } |
There was a problem hiding this comment.
This is not correct, as there can be both successful and unsuccessful data as part of a single SelectionData.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6752