Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that query id has a valid format. #6950

Merged
merged 5 commits into from
Feb 29, 2024

Conversation

michaelstaib
Copy link
Member

No description provided.

Copy link

github-actions bot commented Feb 28, 2024

Qodana for .NET

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

Copy link

codecov bot commented Feb 28, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 72.99%. Comparing base (a4d7d5e) to head (c76dc26).

❗ Current head c76dc26 differs from pull request most recent head c30b9d5. Consider uploading reports for the commit c30b9d5 to get more accurate results

Files Patch % Lines
...pNetCore/Serialization/DefaultHttpRequestParser.cs 62.50% 6 Missing ⚠️
...guage/src/Language.Web/Sha1DocumentHashProvider.cs 50.00% 1 Missing ⚠️
...age/src/Language.Web/Sha256DocumentHashProvider.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6950      +/-   ##
==========================================
- Coverage   73.00%   72.99%   -0.02%     
==========================================
  Files        2584     2584              
  Lines      128606   128606              
==========================================
- Hits        93893    93873      -20     
- Misses      34713    34733      +20     
Flag Coverage Δ
unittests 72.99% <75.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@michaelstaib michaelstaib merged commit 7d55af3 into main Feb 29, 2024
9 of 10 checks passed
@michaelstaib michaelstaib deleted the mst/ensure-query-id-is-valid branch February 29, 2024 13:53
@PascalSenn PascalSenn mentioned this pull request May 22, 2024
@PascalSenn PascalSenn mentioned this pull request Jun 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant