Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refined Query Conventions #6880

Merged
merged 8 commits into from
Feb 10, 2024
Merged

Refined Query Conventions #6880

merged 8 commits into from
Feb 10, 2024

Conversation

michaelstaib
Copy link
Member

  • refined query condition code
  • reworked snapshot tests to use markdown documents

Copy link

codecov bot commented Feb 10, 2024

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (1634426) 72.68% compared to head (dc71fcb) 69.41%.

❗ Current head dc71fcb differs from pull request most recent head c8ce7b2. Consider uploading reports for the commit c8ce7b2 to get more accurate results

Files Patch % Lines
...ormatters/ExecutionResultSnapshotValueFormatter.cs 13.33% 13 Missing ⚠️
src/CookieCrumble/src/CookieCrumble/Snapshot.cs 95.38% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6880      +/-   ##
==========================================
- Coverage   72.68%   69.41%   -3.27%     
==========================================
  Files        2569     2583      +14     
  Lines      127682   128318     +636     
==========================================
- Hits        92809    89078    -3731     
- Misses      34873    39240    +4367     
Flag Coverage Δ
unittests 69.41% <82.41%> (-3.27%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Feb 10, 2024

Qodana for .NET

55 new problems were found

Inspection name Severity Problems
Possible 'null' assignment to non-nullable entity 🔶 Warning 18
Redundant using directive 🔶 Warning 15
Namespace does not correspond to file location 🔶 Warning 7
Redundant type declaration body 🔶 Warning 5
Member hides static member from outer class 🔶 Warning 3
Redundant cast 🔶 Warning 3
Get-only auto-property is never assigned 🔶 Warning 2
Unused local variable 🔶 Warning 2

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

@michaelstaib michaelstaib merged commit d9b3a66 into main Feb 10, 2024
85 of 94 checks passed
@michaelstaib michaelstaib deleted the mst/error-refinements branch February 10, 2024 09:46
@PascalSenn PascalSenn mentioned this pull request Feb 19, 2024
@PascalSenn PascalSenn mentioned this pull request May 22, 2024
@PascalSenn PascalSenn mentioned this pull request Jun 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant