Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed result formatting when non-null root field becomes null. #6844

Merged
merged 3 commits into from
Jan 23, 2024

Conversation

michaelstaib
Copy link
Member

No description provided.

Copy link

github-actions bot commented Jan 22, 2024

Qodana for .NET

13 new problems were found

Inspection name Severity Problems
Redundant using directive 🔶 Warning 5
Return type of a function can be non-nullable 🔶 Warning 3
Conditional access qualifier expression is not null according to nullable reference types' annotations 🔶 Warning 1
Inconsistent synchronization on field 🔶 Warning 1
Non-accessed field (private accessibility) 🔶 Warning 1
Type member is never used (private accessibility) 🔶 Warning 1
Unused parameter (private accessibility) 🔶 Warning 1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

Copy link

codecov bot commented Jan 22, 2024

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (8bf1558) 70.16% compared to head (614c8a5) 73.02%.

Files Patch % Lines
...src/Execution/Serialization/JsonResultFormatter.cs 66.66% 5 Missing ⚠️
...ate/Core/src/Abstractions/Execution/QueryResult.cs 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6844      +/-   ##
==========================================
+ Coverage   70.16%   73.02%   +2.86%     
==========================================
  Files        2485     2499      +14     
  Lines      125521   126157     +636     
==========================================
+ Hits        88067    92122    +4055     
+ Misses      37454    34035    -3419     
Flag Coverage Δ
unittests 73.02% <72.72%> (+2.86%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@michaelstaib michaelstaib merged commit 2f25317 into main Jan 23, 2024
92 of 99 checks passed
@michaelstaib michaelstaib deleted the mst/error-formatting branch January 23, 2024 09:24
@PascalSenn PascalSenn mentioned this pull request Feb 19, 2024
smfeest added a commit to smfeest/buttercup that referenced this pull request Mar 3, 2024
Release 13.9.0 contains a change [1] that affects the response format
when a non-nullable root field cannot be retrieved.

Previously the `data` property would be omitted in these cases, now it
is included with a null value.

[1] ChilliCream/graphql-platform#6844
@PascalSenn PascalSenn mentioned this pull request May 22, 2024
@PascalSenn PascalSenn mentioned this pull request Jun 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant