Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use global namespace to resolve System.Text.Json #6822

Merged

Conversation

aidy-jenkins
Copy link
Contributor

Fixes a potential build issue where System.Text.Json could not be resolved, depending on project/namespace name

  • Updated code generator with fix
  • Updated snapshots with new ref

Closes #6820

Copy link
Contributor

@AntonC9018 AntonC9018 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Jan 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9a718ee) 73.69% compared to head (476b0a1) 70.91%.

❗ Current head 476b0a1 differs from pull request most recent head 952f1cd. Consider uploading reports for the commit 952f1cd to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6822      +/-   ##
==========================================
- Coverage   73.69%   70.91%   -2.78%     
==========================================
  Files        2534     2520      -14     
  Lines      127238   126602     -636     
==========================================
- Hits        93763    89777    -3986     
- Misses      33475    36825    +3350     
Flag Coverage Δ
unittests 70.91% <100.00%> (-2.78%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@michaelstaib michaelstaib merged commit 34c343c into ChilliCream:main Jan 16, 2024
89 of 96 checks passed
@PascalSenn PascalSenn mentioned this pull request Feb 19, 2024
@PascalSenn PascalSenn mentioned this pull request May 22, 2024
@PascalSenn PascalSenn mentioned this pull request Jun 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build fails due to incorrect namespace resolution
3 participants