WIP: Apollo Federation V2 merge

[AntonC9018]

No description provided.

[codecov]

Codecov Report

Attention: 55 lines in your changes are missing coverage. Please review.

Comparison is base (584b932) 70.89% compared to head (3a81bde) 70.94%.
Report is 3 commits behind head on main.

❗ Current head 3a81bde differs from pull request most recent head 3c27293. Consider uploading reports for the commit 3c27293 to get more accurate results

Files	Patch %	Lines
...olloFederation/src/ApolloFederation/ThrowHelper.cs	16.66%	15 Missing ⚠️
.../Types/Extensions/SchemaBuilderExtensions.Types.cs	38.46%	8 Missing ⚠️
...arameters/ScopedStateParameterExpressionBuilder.cs	42.85%	4 Missing ⚠️
...te/Core/src/Types/Types/Scalars/Iso8601Duration.cs	0.00%	4 Missing ⚠️
...tCore/Extensions/EndpointRouteBuilderExtensions.cs	84.21%	3 Missing ⚠️
...colate/Core/src/Types/Types/DirectiveCollection.cs	72.72%	3 Missing ⚠️
...ensions/ApolloFederationSchemaBuilderExtensions.cs	86.66%	2 Missing ⚠️
...Parameters/LocalStateParameterExpressionBuilder.cs	66.66%	2 Missing ⚠️
...ypes/Types/Interceptors/FlagEnumTypeInterceptor.cs	0.00%	2 Missing ⚠️
...polloFederationRequestExecutorBuilderExtensions.cs	66.66%	1 Missing ⚠️
... and 11 more

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #6769      +/-   ##
==========================================
+ Coverage   70.89%   70.94%   +0.05%     
==========================================
  Files        2520     2520              
  Lines      126678   126686       +8     
==========================================
+ Hits        89805    89877      +72     
+ Misses      36873    36809      -64     

Flag	Coverage Δ
unittests	70.94% <82.02%> (+0.05%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

Qodana for .NET

19 new problems were found

Inspection name	Severity	Problems
Declaring new protected member in sealed class is the same as declaring it as private	🔴 Failure	1
Namespace does not correspond to file location	🔶 Warning	17
Type member is never used (private accessibility)	🔶 Warning	1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

• Or via our issue tracker: https://jb.gg/qodana-issue
• Or share your feedback: https://jb.gg/qodana-discussions

[AntonC9018]

Some notes on the unsupported / untested features of Apollo Federation V2:

Selective directive imports is not easily configurable currently, and could be used in tests.

Renaming imports is not supported. Namespacing doesn't work either, pretty sure?

Not sure about extends. I'm going to look into this more.

Shareable needs a test to make sure it's applied to all fields of an object.

Validation for inaccessible (fields returning inaccessible must be inaccessible). Maybe should add optional cascading behavior here?

External has functional implications (it shouldn't allow accessing the field by default), but I think it's not respected. provides that has to do with this isn't validated either.

Not sure if "... on Person { name address }" syntax for provides is supported / validated.

requires needs validation for the presence of external on the fields listed.

There are unimplemented directives for 2.6:

• Policy

[michaelstaib]

Superseded by #6837