Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial Preparations For Version 14 #6655

Merged
merged 3 commits into from
Nov 1, 2023
Merged

Conversation

michaelstaib
Copy link
Member

  • Removed Neo4J (No replacement)
  • Removed Stitching (Replaced by HotChocolate.Fusion)
  • Removed OLD Filtering (Replaced by HotChocolate.Data)

Copy link

codecov bot commented Nov 1, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (6965960) 78.98% compared to head (e32a2f1) 78.23%.
Report is 55 commits behind head on main.

❗ Current head e32a2f1 differs from pull request most recent head f91edee. Consider uploading reports for the commit f91edee to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6655      +/-   ##
==========================================
- Coverage   78.98%   78.23%   -0.75%     
==========================================
  Files        2903     2935      +32     
  Lines      139771   141720    +1949     
==========================================
+ Hits       110397   110877     +480     
- Misses      29374    30843    +1469     
Flag Coverage Δ
unittests 78.23% <88.88%> (-0.75%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...e/src/CookieCrumble/Extensions/WriterExtensions.cs 100.00% <ø> (ø)
...CookieCrumble/src/CookieCrumble/TestEnvironment.cs 0.00% <ø> (ø)
...polloFederationRequestExecutorBuilderExtensions.cs 66.66% <100.00%> (ø)
...ensions/ApolloFederationSchemaBuilderExtensions.cs 86.66% <ø> (ø)
.../src/ApolloFederation/FederationTypeInterceptor.cs 100.00% <100.00%> (ø)
...ion/src/ApolloFederation/Helpers/ArgumentParser.cs 68.65% <100.00%> (+0.47%) ⬆️
...rc/AspNetCore.CommandLine/Command/ExportCommand.cs 100.00% <100.00%> (ø)
...rc/AspNetCore/Extensions/HttpResponseExtensions.cs 26.31% <ø> (+4.57%) ⬆️
...olate/AspNetCore/src/AspNetCore/HeaderUtilities.cs 80.85% <ø> (ø)
...ate/AspNetCore/src/AspNetCore/HttpGetMiddleware.cs 82.31% <ø> (ø)
... and 9 more

... and 410 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tobias-tengler
Copy link
Collaborator

tobias-tengler commented Nov 1, 2023

All the deprecated methods on the type descriptors and request builder should go as well 🙏

@michaelstaib
Copy link
Member Author

@tobias-tengler yes .... do you want to do a separate PR ... I will merge this one and focus on warnings for my next one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants