-
-
Notifications
You must be signed in to change notification settings - Fork 749
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor CookieCrumble to abstract test frameworks #6537
Merged
michaelstaib
merged 10 commits into
ChilliCream:main
from
stuartjbrown:feat/refactor-into-test-frameworks
Nov 29, 2024
Merged
Refactor CookieCrumble to abstract test frameworks #6537
michaelstaib
merged 10 commits into
ChilliCream:main
from
stuartjbrown:feat/refactor-into-test-frameworks
Nov 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuartjbrown
changed the title
Feat/refactor into test frameworks
Refactor CookieCrumble to abstract test frameworks
Sep 14, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6537 +/- ##
=======================================
Coverage 74.32% 74.32%
=======================================
Files 2860 2867 +7
Lines 149842 149872 +30
Branches 17411 17414 +3
=======================================
+ Hits 111373 111396 +23
- Misses 32671 32673 +2
- Partials 5798 5803 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
michaelstaib
force-pushed
the
main
branch
2 times, most recently
from
June 17, 2024 17:49
8a97a79
to
e2d2300
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the test framework specific logic / code into their own assemblies in order to avoid polluting the CookieCrumble project with test framework specific references. This means that a small amount of (global) setup is needed before using Snapshot.
ITestFramework
to abstract the test framework specific logicCookieCrumble.MSTest
andCookieCrumble.Xunit
)