Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor CookieCrumble to abstract test frameworks #6537

Merged

Conversation

stuartjbrown
Copy link
Contributor

Refactor the test framework specific logic / code into their own assemblies in order to avoid polluting the CookieCrumble project with test framework specific references. This means that a small amount of (global) setup is needed before using Snapshot.

  • Added an interface ITestFramework to abstract the test framework specific logic
  • Added 2 projects with the test framework specific implementation (CookieCrumble.MSTest and CookieCrumble.Xunit)
  • Added a test project for MSTest and updated the existing one which uses Xunit

@stuartjbrown stuartjbrown changed the title Feat/refactor into test frameworks Refactor CookieCrumble to abstract test frameworks Sep 14, 2023
@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.32%. Comparing base (c477e13) to head (b6d6814).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6537   +/-   ##
=======================================
  Coverage   74.32%   74.32%           
=======================================
  Files        2860     2867    +7     
  Lines      149842   149872   +30     
  Branches    17411    17414    +3     
=======================================
+ Hits       111373   111396   +23     
- Misses      32671    32673    +2     
- Partials     5798     5803    +5     
Flag Coverage Δ
unittests 74.32% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChilliCream ChilliCream deleted a comment from github-actions bot Jun 5, 2024
@ChilliCream ChilliCream deleted a comment from github-actions bot Jun 5, 2024
@ChilliCream ChilliCream deleted a comment from github-actions bot Jun 5, 2024
@michaelstaib michaelstaib force-pushed the main branch 2 times, most recently from 8a97a79 to e2d2300 Compare June 17, 2024 17:49
@glen-84 glen-84 marked this pull request as ready for review November 29, 2024 16:13
@michaelstaib michaelstaib merged commit 3e068ce into ChilliCream:main Nov 29, 2024
102 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants