Fixed array writer reset

ChilliCream · Nov 23, 2023 · 9a5ffc1 · 9a5ffc1
1 parent a3838e3
commit 9a5ffc1
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 2 deletions.
diff --git a/src/HotChocolate/Utilities/src/Utilities/ArrayWriter.cs b/src/HotChocolate/Utilities/src/Utilities/ArrayWriter.cs
@@ -156,7 +156,7 @@ public Span<byte> GetSpan(int sizeHint = 0)
         EnsureBufferCapacity(size);
         return _buffer.AsSpan().Slice(_start, size);
     }
-    
+
     /// <summary>
     /// Gets the buffer as an <see cref="ArraySegment{T}"/>
     /// </summary>
@@ -204,7 +204,11 @@ private void EnsureBufferCapacity(int neededCapacity)
         }
     }
 
-    public void Reset() => _start = 0;
+    public void Reset()
+    {
+        _capacity = _buffer.Length;
+        _start = 0;
+    }
 
     /// <inheritdoc/>
     public void Dispose()

diff --git a/src/HotChocolate/Utilities/test/Utilities.Tests/ArrayWriterTests.cs b/src/HotChocolate/Utilities/test/Utilities.Tests/ArrayWriterTests.cs
@@ -248,4 +248,18 @@ public void ShouldAllocateSufficientMemory()
         writer.Advance (0x2000) ;
         writer.GetSpan (0x7000) ;
     }
+
+    [Fact]
+    public void ShouldResetCapacity()
+    {
+        // Arrange
+        using var writer = new ArrayWriter();
+
+        // Act
+        writer.GetSpan(1000);
+        writer.Advance(1000);
+        writer.Reset();
+        writer.GetSpan(2000);
+        writer.Advance(2000);
+    }
 }