Add first round of tests

ChilliCream · Nov 13, 2024 · 83e7547 · 83e7547
1 parent 09a5408
commit 83e7547
Show file tree

Hide file tree

Showing 2 changed files with 501 additions and 5 deletions.
diff --git a/src/HotChocolate/Core/src/Types/SemanticNonNullTypeInterceptor.cs b/src/HotChocolate/Core/src/Types/SemanticNonNullTypeInterceptor.cs
@@ -60,9 +60,13 @@ public override void OnAfterCompleteName(ITypeCompletionContext completionContex
                     continue;
                 }
 
-                ApplySemanticNonNullDirective(field, completionContext);
+                // TODO: This is not correct for lists
+                var hasSemanticNonNull = ApplySemanticNonNullDirective(field, completionContext);
 
-                field.FormatterDefinitions.Add(CreateSemanticNonNullResultFormatterDefinition());
+                if (hasSemanticNonNull)
+                {
+                    field.FormatterDefinitions.Add(CreateSemanticNonNullResultFormatterDefinition());
+                }
             }
         }
         else if (definition is InterfaceTypeDefinition interfaceDef)
@@ -80,20 +84,20 @@ public override void OnAfterCompleteName(ITypeCompletionContext completionContex
         }
     }
 
-    private void ApplySemanticNonNullDirective(
+    private bool ApplySemanticNonNullDirective(
         OutputFieldDefinitionBase field,
         ITypeCompletionContext completionContext)
     {
         if (field.Type is null)
         {
-            return;
+            return false;
         }
 
         var levels = GetSemanticNonNullLevels(field.Type);
 
         if (levels.Count < 1)
         {
-            return;
+            return false;
         }
 
         var directiveDependency = new TypeDependency(
@@ -105,6 +109,8 @@ private void ApplySemanticNonNullDirective(
         field.AddDirective(new SemanticNonNullDirective(levels), _typeInspector);
 
         field.Type = BuildNullableTypeStructure(field.Type, _typeInspector);
+
+        return true;
     }
 
     private static List<int> GetSemanticNonNullLevels(TypeReference typeReference)