Better error message for failing conversion (#819)

ChilliCream · Jun 6, 2019 · 810e581 · 810e581
1 parent 91d1c4f
commit 810e581
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 1 deletion.
diff --git a/src/Core/Types/Properties/TypeResources.Designer.cs b/src/Core/Types/Properties/TypeResources.Designer.cs
diff --git a/src/Core/Types/Properties/TypeResources.resx b/src/Core/Types/Properties/TypeResources.resx
@@ -578,4 +578,7 @@ Type: `{0}`</value>
   <data name="TypeRegistrar_TypesInconsistent" xml:space="preserve">
     <value>Unable to infer or resolve a schema type from the type reference `{0}`.</value>
   </data>
+  <data name="TypeConvertion_ConvertNotSupported" xml:space="preserve">
+    <value>Unable to convert type from `{0}` to `{1}`</value>
+  </data>
 </root>
diff --git a/src/Core/Types/Utilities/TypeConversion.cs b/src/Core/Types/Utilities/TypeConversion.cs
@@ -2,6 +2,7 @@
 using System.Collections.Concurrent;
 using System.Collections.Generic;
 using System.Collections.Immutable;
+using HotChocolate.Properties;
 
 namespace HotChocolate.Utilities
 {
@@ -38,7 +39,11 @@ public object Convert(Type from, Type to, object source)
         {
             if (!TryConvert(from, to, source, out object converted))
             {
-                throw new NotSupportedException();
+                throw new NotSupportedException(
+                    string.Format(
+                        TypeResources.TypeConvertion_ConvertNotSupported,
+                        from.Name,
+                        to.Name));
             }
             return converted;
         }