Fixed Warnings (#6661)

ChilliCream · Nov 2, 2023 · 2453428 · 2453428
1 parent 4680c84
commit 2453428
Show file tree

Hide file tree

Showing 93 changed files with 2,101 additions and 724 deletions.
diff --git a/src/Directory.Build.props b/src/Directory.Build.props
@@ -1,18 +1,21 @@
 <Project>
 
-  <PropertyGroup>
-    <IsMacOsArm Condition="'$(NETCoreSdkPortableRuntimeIdentifier)' == 'osx-arm64'">true</IsMacOsArm>
-  </PropertyGroup>
-
   <PropertyGroup>
     <LangVersion>preview</LangVersion>
     <Version Condition="$(Version) == ''">0.0.0</Version>
-    <NoWarn>$(NoWarn);CS0436;RS0026;RS0027;RS0041</NoWarn>
+    <NoWarn>$(NoWarn);CS0436;RS0026;RS0027;RS0041;AD0001;CS1591;NU5104;NU5128;NU5501</NoWarn>
+  </PropertyGroup>
+
+  <PropertyGroup Condition="'$(Configuration)' == 'debug'">
+    <GenerateDocumentationFile>false</GenerateDocumentationFile>
+    <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
+    <WarningsAsErrors>$(WarningsAsErrors);nullable</WarningsAsErrors>
   </PropertyGroup>
 
-  <PropertyGroup Condition="'$(Configuration)' == 'Release'">
+  <PropertyGroup Condition="'$(Configuration)' == 'release'">
     <GenerateDocumentationFile>true</GenerateDocumentationFile>
-    <NoWarn>$(NoWarn);CS1591;NU5104</NoWarn>
+    <TreatWarningsAsErrors>false</TreatWarningsAsErrors>
+    <WarningsAsErrors>$(WarningsAsErrors);nullable</WarningsAsErrors>
   </PropertyGroup>
 
   <PropertyGroup>

diff --git a/src/GreenDonut/test/Directory.Build.props b/src/GreenDonut/test/Directory.Build.props
@@ -4,6 +4,8 @@
   <PropertyGroup>
     <TargetFrameworks>$(TestTargetFrameworks)</TargetFrameworks>
     <IsPackable>false</IsPackable>
+    <GenerateDocumentationFile>false</GenerateDocumentationFile>
+    <TreatWarningsAsErrors>false</TreatWarningsAsErrors>
   </PropertyGroup>
 
   <ItemGroup>

diff --git a/src/HotChocolate/ApolloFederation/test/Directory.Build.props b/src/HotChocolate/ApolloFederation/test/Directory.Build.props
@@ -3,6 +3,8 @@
 
   <PropertyGroup>
     <IsPackable>false</IsPackable>
+    <GenerateDocumentationFile>false</GenerateDocumentationFile>
+    <TreatWarningsAsErrors>false</TreatWarningsAsErrors>
   </PropertyGroup>
 
   <ItemGroup>

diff --git a/...ocolate/AspNetCore/src/AspNetCore.Authorization.Opa/Request/DefaultQueryRequestFactory.cs b/...ocolate/AspNetCore/src/AspNetCore.Authorization.Opa/Request/DefaultQueryRequestFactory.cs
@@ -29,16 +29,16 @@ public OpaQueryRequest CreateRequest(AuthorizationContext context, AuthorizeDire
             httpContext.Request.Headers,
             httpContext.Request.Host.Value,
             httpContext.Request.Method,
-            httpContext.Request.Path.Value,
+            httpContext.Request.Path.Value!,
             httpContext.Request.Query,
             httpContext.Request.Scheme);
 
         var source = new IPAndPort(
-            connection.RemoteIpAddress.ToString(),
+            connection.RemoteIpAddress!.ToString(),
             connection.RemotePort);
 
         var destination = new IPAndPort(
-            connection.LocalIpAddress.ToString(),
+            connection.LocalIpAddress!.ToString(),
             connection.LocalPort);
 
         return new OpaQueryRequest(policy, originalRequest, source, destination);

diff --git a/src/HotChocolate/AspNetCore/src/AspNetCore/GraphQLRequestException.cs b/src/HotChocolate/AspNetCore/src/AspNetCore/GraphQLRequestException.cs
@@ -2,7 +2,6 @@
 
 namespace HotChocolate.AspNetCore;
 
-[Serializable]
 public class GraphQLRequestException : GraphQLException
 {
     public GraphQLRequestException(string message)
@@ -25,17 +24,4 @@ public GraphQLRequestException(IEnumerable<IError> errors)
         : base(errors)
     {
     }
-
-#if NET8_0_OR_GREATER
-    [Obsolete(
-        "This API supports obsolete formatter-based serialization. " +
-        "It should not be called or extended by application code.",
-        true)]
-#endif
-    protected GraphQLRequestException(
-        SerializationInfo info,
-        StreamingContext context)
-        : base(info, context)
-    {
-    }
 }
diff --git a/src/HotChocolate/AspNetCore/src/AspNetCore/Instrumentation/IServerDiagnosticEvents.cs b/src/HotChocolate/AspNetCore/src/AspNetCore/Instrumentation/IServerDiagnosticEvents.cs
@@ -145,7 +145,7 @@ void StartOperationBatchRequest(
     /// <param name="context">
     /// The <see cref="HttpContext"/>.
     /// </param>
-    /// <param name="errors">
+    /// <param name="exception">
     /// The <see cref="Exception"/>.
     /// </param>
     void WebSocketSessionError(HttpContext context, Exception exception);

diff --git a/...e/AspNetCore/test/AspNetCore.Tests.Utilities/Subscriptions/Apollo/SubscriptionTestBase.cs b/...e/AspNetCore/test/AspNetCore.Tests.Utilities/Subscriptions/Apollo/SubscriptionTestBase.cs
@@ -104,7 +104,7 @@ protected async Task<WebSocket> ConnectToServerAsync(
     protected static WebSocketClient CreateWebSocketClient(TestServer testServer)
     {
         var client = testServer.CreateWebSocketClient();
-        client.ConfigureRequest = r => r.Headers.Add("Sec-WebSocket-Protocol", "graphql-ws");
+        client.ConfigureRequest = r => r.Headers.SecWebSocketProtocol = "graphql-ws";
         return client;
     }
 

diff --git a/...est/AspNetCore.Tests.Utilities/Subscriptions/GraphQLOverWebSocket/SubscriptionTestBase.cs b/...est/AspNetCore.Tests.Utilities/Subscriptions/GraphQLOverWebSocket/SubscriptionTestBase.cs
@@ -104,9 +104,7 @@ protected async Task<WebSocket> ConnectToServerAsync(
     protected static WebSocketClient CreateWebSocketClient(TestServer testServer)
     {
         var client = testServer.CreateWebSocketClient();
-        client.ConfigureRequest = r => r.Headers.Add(
-            "Sec-WebSocket-Protocol",
-            WellKnownProtocols.GraphQL_Transport_WS);
+        client.ConfigureRequest = r => r.Headers.SecWebSocketProtocol = WellKnownProtocols.GraphQL_Transport_WS;
         return client;
     }
 

diff --git a/...Chocolate/AspNetCore/test/AspNetCore.Tests/Subscriptions/Apollo/WebSocketProtocolTests.cs b/...Chocolate/AspNetCore/test/AspNetCore.Tests/Subscriptions/Apollo/WebSocketProtocolTests.cs
@@ -193,7 +193,7 @@ public Task Connect_With_Invalid_Protocol()
             using var testServer = CreateStarWarsServer();
             var client = testServer.CreateWebSocketClient();
 
-            client.ConfigureRequest = r => r.Headers.Add("Sec-WebSocket-Protocol", "foo");
+            client.ConfigureRequest = r => r.Headers.SecWebSocketProtocol = "foo";
 
             // act
             var socket = await client.ConnectAsync(SubscriptionUri, ct);

diff --git a/...etCore/test/AspNetCore.Tests/Subscriptions/GraphQLOverWebSocket/WebSocketProtocolTests.cs b/...etCore/test/AspNetCore.Tests/Subscriptions/GraphQLOverWebSocket/WebSocketProtocolTests.cs
@@ -228,7 +228,7 @@ public Task Connect_With_Invalid_Protocol()
                 var client = testServer.CreateWebSocketClient();
 
                 // act
-                client.ConfigureRequest = r => r.Headers.Add("Sec-WebSocket-Protocol", "foo");
+                client.ConfigureRequest = r => r.Headers.SecWebSocketProtocol = "foo";
                 using var socket = await client.ConnectAsync(SubscriptionUri, ct);
 
                 // assert

diff --git a/src/HotChocolate/AspNetCore/test/Directory.Build.props b/src/HotChocolate/AspNetCore/test/Directory.Build.props
@@ -5,7 +5,8 @@
     <IsPackable>false</IsPackable>
     <Nullable>enable</Nullable>
     <ImplicitUsings>enable</ImplicitUsings>
-    <Warn>0</Warn>
+    <GenerateDocumentationFile>false</GenerateDocumentationFile>
+    <TreatWarningsAsErrors>false</TreatWarningsAsErrors>
   </PropertyGroup>
 
   <ItemGroup>

diff --git a/...e/AzureFunctions/src/HotChocolate.AzureFunctions.IsolatedProcess/AzureHeaderDictionary.cs b/...e/AzureFunctions/src/HotChocolate.AzureFunctions.IsolatedProcess/AzureHeaderDictionary.cs
@@ -19,7 +19,7 @@ public AzureHeaderDictionary(HttpResponse response, HttpResponseData responseDat
 
     public void Add(KeyValuePair<string, StringValues> item)
     {
-        _response.Headers.Add(item.Key, item.Value);
+        _response.Headers.Append(item.Key, item.Value);
         _responseData.Headers.Add(item.Key, (IEnumerable<string>)item.Value);
     }
 
@@ -52,7 +52,7 @@ public bool Remove(KeyValuePair<string, StringValues> item)
 
     public void Add(string key, StringValues value)
     {
-        _response.Headers.Add(key, value);
+        _response.Headers.Append(key, value);
         _responseData.Headers.Add(key, (IEnumerable<string>)value);
     }
 

diff --git a/src/HotChocolate/AzureFunctions/test/Directory.Build.props b/src/HotChocolate/AzureFunctions/test/Directory.Build.props
@@ -3,7 +3,8 @@
 
   <PropertyGroup>
     <IsPackable>false</IsPackable>
-    <Warn>0</Warn>
+    <GenerateDocumentationFile>false</GenerateDocumentationFile>
+    <TreatWarningsAsErrors>false</TreatWarningsAsErrors>
   </PropertyGroup>
 
   <ItemGroup>

diff --git a/src/HotChocolate/Caching/test/Directory.Build.props b/src/HotChocolate/Caching/test/Directory.Build.props
@@ -3,7 +3,8 @@
 
   <PropertyGroup>
     <IsPackable>false</IsPackable>
-    <Warn>0</Warn>
+    <GenerateDocumentationFile>false</GenerateDocumentationFile>
+    <TreatWarningsAsErrors>false</TreatWarningsAsErrors>
   </PropertyGroup>
 
   <ItemGroup Condition="'$(TargetFramework)' == 'net8.0'">

diff --git a/src/HotChocolate/Core/src/Abstractions/Execution/QueryException.cs b/src/HotChocolate/Core/src/Abstractions/Execution/QueryException.cs
@@ -1,10 +1,7 @@
-using System;
 using System.Collections.Generic;
-using System.Runtime.Serialization;
 
 namespace HotChocolate.Execution;
 
-[Serializable]
 public class QueryException
     : GraphQLException
 {
@@ -28,17 +25,4 @@ public QueryException(IEnumerable<IError> errors)
         : base(errors)
     {
     }
-
-#if NET8_0_OR_GREATER
-    [Obsolete(
-        "This API supports obsolete formatter-based serialization. " +
-        "It should not be called or extended by application code.",
-        true)]
-#endif
-    protected QueryException(
-        SerializationInfo info,
-        StreamingContext context)
-        : base(info, context)
-    {
-    }
 }
diff --git a/src/HotChocolate/Core/src/Abstractions/Execution/QueryRequestBuilderException.cs b/src/HotChocolate/Core/src/Abstractions/Execution/QueryRequestBuilderException.cs
@@ -2,7 +2,6 @@
 
 namespace HotChocolate.Execution;
 
-[Serializable]
 public class QueryRequestBuilderException : Exception
 {
     public QueryRequestBuilderException() { }
@@ -12,15 +11,4 @@ public QueryRequestBuilderException(string message)
 
     public QueryRequestBuilderException(string message, Exception inner)
         : base(message, inner) { }
-
-#if NET8_0_OR_GREATER
-    [Obsolete(
-        "This API supports obsolete formatter-based serialization. " +
-        "It should not be called or extended by application code.",
-        true)]
-#endif
-    protected QueryRequestBuilderException(
-      System.Runtime.Serialization.SerializationInfo info,
-      System.Runtime.Serialization.StreamingContext context)
-        : base(info, context) { }
 }
diff --git a/src/HotChocolate/Core/src/Abstractions/GraphQLException.cs b/src/HotChocolate/Core/src/Abstractions/GraphQLException.cs
@@ -1,12 +1,10 @@
-#pragma warning disable RCS1194 
+#pragma warning disable RCS1194
 
 using System;
 using System.Collections.Generic;
-using System.Runtime.Serialization;
 
 namespace HotChocolate;
 
-[Serializable]
 public class GraphQLException : Exception
 {
     public GraphQLException(string message)
@@ -46,19 +44,5 @@ public GraphQLException(string message, Exception innerException)
         };
     }
 
-#if NET8_0_OR_GREATER
-    [Obsolete(
-        "This API supports obsolete formatter-based serialization. " +
-        "It should not be called or extended by application code.",
-        true)]
-#endif
-    protected GraphQLException(
-        SerializationInfo info,
-        StreamingContext context)
-        : base(info, context)
-    {
-        Errors = Array.Empty<IError>();
-    }
-
     public IReadOnlyList<IError> Errors { get; }
 }
diff --git a/src/HotChocolate/Core/src/Execution/AutoUpdateRequestExecutorProxy.cs b/src/HotChocolate/Core/src/Execution/AutoUpdateRequestExecutorProxy.cs
@@ -136,9 +136,6 @@ public Task<IExecutionResult> ExecuteAsync(
     /// <param name="requestBatch">
     /// The GraphQL request batch.
     /// </param>
-    /// <param name="allowParallelExecution">
-    /// Defines if the executor is allowed to execute the batch in parallel.
-    /// </param>
     /// <param name="cancellationToken">
     /// The cancellation token.
     /// </param>

diff --git a/...olate/Core/src/Execution/DependencyInjection/InternalSchemaServiceCollectionExtensions.cs b/...olate/Core/src/Execution/DependencyInjection/InternalSchemaServiceCollectionExtensions.cs
@@ -47,8 +47,8 @@ internal static IServiceCollection TryAddTimespanProvider(
         return services;
     }
 
-    public static T GetApplicationService<T>(this IServiceProvider services) =>
-        services.GetApplicationServices().GetRequiredService<T>();
+    public static T GetApplicationService<T>(this IServiceProvider services) where T : notnull
+        => services.GetApplicationServices().GetRequiredService<T>();
 
     public static IServiceProvider GetApplicationServices(this IServiceProvider services) =>
         services.GetRequiredService<IApplicationServiceProvider>();

diff --git a/...ore/src/Execution/DependencyInjection/RequestExecutorBuilderExtensions.Instrumentation.cs b/...ore/src/Execution/DependencyInjection/RequestExecutorBuilderExtensions.Instrumentation.cs
@@ -51,7 +51,7 @@ public static IRequestExecutorBuilder AddDiagnosticEventListener<T>(
         else if (typeof(IDataLoaderDiagnosticEventListener).IsAssignableFrom(typeof(T)))
         {
             builder.Services.TryAddSingleton<T>();
-            builder.Services.AddSingleton(s => (IDataLoaderDiagnosticEventListener)s.GetService<T>());
+            builder.Services.AddSingleton(s => (IDataLoaderDiagnosticEventListener)s.GetRequiredService<T>());
         }
         else if (typeof(T).IsDefined(typeof(DiagnosticEventSourceAttribute), true))
         {
@@ -61,7 +61,7 @@ public static IRequestExecutorBuilder AddDiagnosticEventListener<T>(
                 typeof(T).GetCustomAttributes(typeof(DiagnosticEventSourceAttribute), true))
             {
                 var listener = ((DiagnosticEventSourceAttribute)attribute).Listener;
-                builder.Services.AddSingleton(listener, s => s.GetService<T>());
+                builder.Services.AddSingleton(listener, s => s.GetRequiredService<T>());
             }
         }
         else

diff --git a/...ore/src/Execution/DependencyInjection/SchemaRequestExecutorBuilderExtensions.Resolvers.cs b/...ore/src/Execution/DependencyInjection/SchemaRequestExecutorBuilderExtensions.Resolvers.cs
@@ -556,7 +556,7 @@ public static IRequestExecutorBuilder AddResolver(
     /// Adds a custom parameter expression builder to the resolver compiler.
     /// </summary>
     /// <param name="builder">
-    /// The <see cref="IResolverCompilerBuilder"/>.
+    /// The <see cref="IResolverCompiler"/>.
     /// </param>
     /// <param name="expression">
     /// A expression that resolves the data for the custom parameter.
@@ -569,7 +569,7 @@ public static IRequestExecutorBuilder AddResolver(
     /// The parameter result type.
     /// </typeparam>
     /// <returns>
-    /// An <see cref="IResolverCompilerBuilder"/> that can be used to configure to
+    /// An <see cref="IResolverCompiler"/> that can be used to configure to
     /// chain in more configuration.
     /// </returns>
     public static IRequestExecutorBuilder AddParameterExpressionBuilder<T>(