-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Videos support #15
Open
rafsanjani
wants to merge
10
commits into
ChiliLabs:master
Choose a base branch
from
rafsanjani:videos-support
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Videos support #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for your contribution. |
@APetjko The thought actually crossed my mind. I will see if I can work on it over the weekend. |
@APetjko Self Isolation in the UK has given me some time to add support for choosing both videos and photos. You might want to check it out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been using this very useful library a lot so I decided to add the support for choosing and taking videos. I have also upgraded all dependencies to latest versions and made appropriate syntax corrections where necessary.
This can be activated by passing an optional parameter
pickerType
to thenewInstance
method.By default only photos can be selected.
Videos Selection
Mixture of Videos and Photos
Almost every core class has been renamed (apparently we can't keep the photo prefixes because there is video suppport now) so this enhancement causes a breaking change.
These are the classes that have changed.
SelectablePhoto
SelectableMedia
PhotoPickerFragment
MediaPickerFragment
PhotoPickerAdapter
MediaPickerAdapter
Consumers of this class only need to worry about renaming
PhotoPickerFragment
toMediaPickerFragment
and the callback from
PhotoPickerFragment.Callback
toMediaPickerFragment.Callback
Everything else remains the same.