-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve DESCRIPTION #47
Changes from 8 commits
23db73c
6b13eeb
2916b7a
ce84fd7
b377cc7
0fe2457
04bb245
cc1ba9f
f4f7beb
bb8123c
2da69f1
4ebbaf6
8c5a9be
5403fdb
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,5 @@ | ||
Package: RSocrata | ||
Type: Package | ||
Title: Download 'Socrata' Data Sets as R Data Frames | ||
Description: Provides easier interaction with | ||
Socrata open data portals http://dev.socrata.com. | ||
|
@@ -8,18 +9,23 @@ Description: Provides easier interaction with | |
returns an R data frame. | ||
Converts dates to 'POSIX' format. | ||
Manages throttling by 'Socrata'. | ||
Version: 1.6.1-2 | ||
Date: 2015-6-5 | ||
URL: https://github.com/Chicago/RSocrata | ||
BugReports: https://github.com/Chicago/RSocrata/issues | ||
Imports: | ||
httr (>= 0.3), | ||
jsonlite (>= 0.9.14), | ||
mime (>= 0.2), | ||
Version: 1.6.2 | ||
Date: 2015-6-8 | ||
Authors@R: c( | ||
person("Hugh", "Devlin, Ph. D.", role = c("aut")), | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Shouldn't we keep the URL and BugReports? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It's a specious remove. The lines are "added" (i.e., kept) on lines 29 and 30 in the new file. |
||
person("Tom", "Schenk", role = c("cre"), email = "[email protected]"), | ||
person("John", "Malc", email = "[email protected]", role = c("ctb"), comment = "@dmpe") | ||
) | ||
Maintainer: Tom Schenk <[email protected]> | ||
Depends: | ||
curl (>= 0.5) | ||
R (>= 3.0.0) | ||
Imports: | ||
httr (>= 1.0.0), | ||
jsonlite (>= 0.9.16), | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. to check |
||
mime (>= 0.3) | ||
Suggests: | ||
RUnit | ||
Author: Hugh Devlin, Ph. D. and Tom Schenk, Jr. | ||
Maintainer: Tom Schenk Jr <[email protected]> | ||
RUnit, | ||
roxygen2 (>= 4.1.0) | ||
License: MIT + file LICENSE | ||
URL: https://github.com/Chicago/RSocrata | ||
BugReports: https://github.com/Chicago/RSocrata/issues |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,14 @@ | ||
# Generated by roxygen2 (4.1.1): do not edit by hand | ||
|
||
export(fieldName) | ||
export(ls.socrata) | ||
export(posixify) | ||
export(read.socrata) | ||
export(ls.socrata) | ||
importFrom("httr", "parse_url", "build_url", "http_status", "stop_for_status", "GET", "content") | ||
importFrom("mime", "guess_type") | ||
importFrom("jsonlite", "fromJSON") | ||
import("curl") | ||
importFrom(httr,GET) | ||
importFrom(httr,build_url) | ||
importFrom(httr,content) | ||
importFrom(httr,http_status) | ||
importFrom(httr,parse_url) | ||
importFrom(httr,stop_for_status) | ||
importFrom(jsonlite,fromJSON) | ||
importFrom(mime,guess_type) |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -72,7 +72,7 @@ If you would like to contribute to this project, please see the [contributing do | |
1.4 Add json file format for Socrata downloads. Switch to RJSONIO rom rjson. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We should correct this too. We went from |
||
|
||
1.5 Several changes: | ||
* Swapped ```jsonlite``` to ```RJSONIO``` | ||
* Swapped ```jsonlite``` from ```RJSONIO``` | ||
* Added handling for long and short dates | ||
* Added unit test for reading private datasets | ||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -13,6 +13,7 @@ RnwWeave: Sweave | |
LaTeX: pdfLaTeX | ||
|
||
BuildType: Package | ||
PackageUseDevtools: Yes | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. to invs. |
||
PackageInstallArgs: --no-multiarch --with-keep.source | ||
PackageCheckArgs: --as-cran | ||
PackageRoxygenize: rd,collate,namespace |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll actually change this back to the old
Author
before pushing to CRAN. The CRAN guys are really picky that my email address inAuthors@R
match that of theMaintainer
's email address. However, I like to separate the emails for general contact information from contacting me for package maintenance (CRAN will send e-mail blasts and I also use the email address in other projects I maintain). I prefer theAuthors@R
, but was getting cross with the CRAN submission process so used the old style.