[GD32VF103] Align port to ChibiOS naming conventions and add missing flash sectors counts #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add v1 suffix to all driver folders * Add _CONTRIB suffix to platform sources and includes
14 tasks
fpoussin
approved these changes
Jun 29, 2022
|
LGTM; thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR rectifies inconsistencies in the GD32VF103 port naming scheme:
v1suffix to all driver folders_CONTRIBsuffix to platform sources and includesIt also adds missing flash sectors counts for all known GD32VF103 mcus.
For reviewers: both changes are in individual commits and I have tested that it still compiles with these