Bring clvm_serde from richardkiss/hsms #14
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quexington
force-pushed
the
quex.bring_clvm_serde
branch
from
45e489b to
294a335
Compare
Quexington
force-pushed
the
quex.bring_clvm_serde
branch
from
294a335 to
906c92c
Compare
richardkiss
reviewed
Jan 4, 2024
| v = p.pair[0] | ||
| p = p.pair[1] | ||
| v = Program.to(p.pair[0]) | ||
| p = Program.to(p.pair[1]) | ||
| else: | ||
| v = p | ||
| args.append(des(v)) |
There was a problem hiding this comment.
Instead of your changes, in the current clvm_serde branch, I changed this line 304 like this:
- args.append(des(v))
+ args.append(des(Program.to(v)))
I no longer remember exactly what motivated this change. Maybe you remember what motivated yours. Do think your change is still necessary if you rebase to the current version of clvm_serde?
richardkiss
reviewed
Jan 4, 2024
| "chia_base @ git+https://github.com/richardkiss/chia_base@91d9dba09e316714cf4bc86505587437fe442e48#egg=chia_base", | ||
| "chialisp_puzzles @ git+https://github.com/richardkiss/chialisp_puzzles@eb97cd844b094e6dcd595b5bd6522d3a78eb692c#egg=chialisp_puzzles", | ||
| "chia_base==0.1.4", | ||
| "chialisp_puzzles==0.1.1", |
There was a problem hiding this comment.
This change seems to be included in 25191ed. Try rebasing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.