Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add datalayer connection #91

Merged

Conversation

blackhorseya
Copy link
Contributor

@blackhorseya blackhorseya commented Jun 12, 2023

In this PR, we aim to add a data layer connection in the HttpClient and read the data_layer configuration from chia-config.

@blackhorseya blackhorseya marked this pull request as ready for review June 12, 2023 23:44
@cmmarslender
Copy link
Contributor

Thanks for the PR. I see there is the details in here for getting the http client for datalayer, etc, but no actual datalayer endpoints. Are you planning to add anything RPC calls to datalayer in this PR? (Farmer, for example: https://github.com/Chia-Network/go-chia-libs/blob/main/pkg/rpc/farmer.go)

@blackhorseya
Copy link
Contributor Author

Thanks for the PR. I see there is the details in here for getting the http client for datalayer, etc, but no actual datalayer endpoints. Are you planning to add anything RPC calls to datalayer in this PR? (Farmer, for example: https://github.com/Chia-Network/go-chia-libs/blob/main/pkg/rpc/farmer.go)

In response, I'd like to clarify that in this PR, I didn't intend to implement any actual RPC calls. However, I realize that I overlooked the inclusion of the DataLayerService in client.go.

@blackhorseya
Copy link
Contributor Author

Thanks for the PR. I see there is the details in here for getting the http client for datalayer, etc, but no actual datalayer endpoints. Are you planning to add anything RPC calls to datalayer in this PR? (Farmer, for example: https://github.com/Chia-Network/go-chia-libs/blob/main/pkg/rpc/farmer.go)

In response, I'd like to clarify that in this PR, I didn't intend to implement any actual RPC calls. However, I realize that I overlooked the inclusion of the DataLayerService in client.go.

b59c299

Copy link
Contributor

@cmmarslender cmmarslender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. One minor (but important) change and I think we can merge

pkg/rpc/datalayer.go Outdated Show resolved Hide resolved
Co-authored-by: Chris Marslender <[email protected]>
@cmmarslender cmmarslender merged commit a3e2fad into Chia-Network:main Jun 14, 2023
@blackhorseya blackhorseya deleted the feature/add-datalayer-connection branch June 14, 2023 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants