Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix js interface error identified by fcoleman #91

Merged
merged 8 commits into from
May 21, 2024

Conversation

prozacchiwawa
Copy link
Contributor

Ensure we produce a nil under all circumstances when reading js values.

@coveralls
Copy link

coveralls commented May 17, 2024

Pull Request Test Coverage Report for Build 9162999411

Details

  • 36 of 36 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.08%) to 82.719%

Totals Coverage Status
Change from base Build 9131721021: 0.08%
Covered Lines: 14920
Relevant Lines: 18037

💛 - Coveralls

freddiecoleman
freddiecoleman previously approved these changes May 18, 2024
… to wasm code, add another test verifying that certain negative integers were already handled correctly
Copy link

socket-security bot commented May 20, 2024

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/[email protected] None 0 624 kB caligatio
npm/[email protected] None 0 11.3 kB boo1ean
npm/[email protected] None 0 79.2 kB wlzla000

View full report↗︎

Copy link

socket-security bot commented May 20, 2024

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

@prozacchiwawa prozacchiwawa merged commit cbe7c30 into base May 21, 2024
29 checks passed
@prozacchiwawa prozacchiwawa deleted the 20240517-js-zero-canonical branch May 21, 2024 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants