Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade pyo3 and maturin #67

Merged
merged 2 commits into from
Mar 5, 2024
Merged

Upgrade pyo3 and maturin #67

merged 2 commits into from
Mar 5, 2024

Conversation

prozacchiwawa
Copy link
Contributor

Upgrade to maturin 1.3.2 and pyo3 0.20.2.
API changes in pyo3 include

  • Replacing the arg_n_ from pyfunction to making a pyo3 decorator containing a signature tuple.
  • Py references are no longer passed out of get_item, which also no longer takes isize but usize.
  • Uses of extract are better done as reference captures using .as_ref().

@coveralls
Copy link

coveralls commented Jan 25, 2024

Pull Request Test Coverage Report for Build 7670685288

  • -32 of 32 (0.0%) changed or added relevant lines in 2 files are covered.
  • 8 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.09%) to 82.958%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/py/pyval.rs 0 11 0.0%
src/py/api.rs 0 21 0.0%
Files with Coverage Reduction New Missed Lines %
src/compiler/sexp.rs 1 78.1%
src/py/api.rs 2 9.3%
src/py/cmds.rs 5 31.03%
Totals Coverage Status
Change from base Build 7661630909: -0.09%
Covered Lines: 14876
Relevant Lines: 17932

💛 - Coveralls

Copy link
Contributor

@emlowe emlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@prozacchiwawa
Copy link
Contributor Author

You're done with your stuff and ok with merging this?

@prozacchiwawa prozacchiwawa merged commit 472d45d into base Mar 5, 2024
29 checks passed
@prozacchiwawa prozacchiwawa deleted the 20240124-upgrade-pyo3 branch March 5, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants