Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix compatibility with most recent version of clvm_rs #100

Merged
merged 1 commit into from
Feb 9, 2023
Merged

Conversation

arvidn
Copy link
Contributor

@arvidn arvidn commented Feb 9, 2023

this PR renamed the run_chia_program() function to run_serialized_chia_program().

@arvidn arvidn requested a review from richardkiss February 9, 2023 12:19
@richardkiss
Copy link
Contributor

Shouldn't you bump the version number in setup.py too?

@richardkiss
Copy link
Contributor

Interesting, it isn't in there. We should probably add it as an optional install. Maybe something like

    extras_require=dict(dev=dev_dependencies, rust=rust_dependencies),

here https://github.com/Chia-Network/clvm_tools/blob/main/setup.py#L48

In any case, I'll approve this.

@richardkiss
Copy link
Contributor

And we should probably pin version numbers a bit tighter in python, like we do in rust.

@arvidn arvidn merged commit 26c9d9c into main Feb 9, 2023
@arvidn arvidn deleted the clvm_rs branch February 9, 2023 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants