fix Serializer to correctly restore() #530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arvidn
force-pushed
the
fix-incremental-serialization
branch
from
98a0de3 to
e03dde6
Compare
Pull Request Test Coverage Report for Build 12658875055Details
💛 - Coveralls |
arvidn
commented
Jan 7, 2025
richardkiss
approved these changes
Jan 7, 2025
There was a problem hiding this comment.
Near as I can tell, you've modified it so the sentinel node is now a property of the instance rather than being passed in to .add. I don't completely understand all the other changes made or the genesis of the bug, but I expect you have a pretty good handle on this.
richardkiss
reviewed
Jan 7, 2025
|
yeah, exactly. the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to allow resumption of serialization.
It turns out my original patch wasn't tested quite well enough. This adds a test for the important case of restoring the
Serializerto an earlier state and still be valid to support serialize more CLVM structures.A somewhat unrelated change is to pass in the sentinel node to the
Serializerconstructor, rather than at every call toadd().