-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add functions get_flags_for_height_and_constants()
and get_conditions_from_spendbundle()
#634
Conversation
Pull Request Test Coverage Report for Build 10252201076Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should have test coverage for both of these functions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that test doesn't really cover very much of the functionality of that function. Let's discuss in keybase how we can approach this. The run_block_generator()
tests actually run full blocks and ensure all the conditions it returns match the expected one. Those test cases are defined in separate text files.
a03e3a1
to
54ff4d3
Compare
…Conditions (to enable reusing existing test facilities). Extend the tests to cover the block-generator test cases
…om_spendbundle Extend the tests to cover the block-generator test cases
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test coverage looks good now!
let's make sure to squash the commits when landing this
Otherwise, lgtm |
Also includes Pybindings for these functions