Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ErrorCode comprehensive #482

Merged
merged 2 commits into from
Apr 23, 2024
Merged

Make ErrorCode comprehensive #482

merged 2 commits into from
Apr 23, 2024

Conversation

Rigidity
Copy link
Contributor

@Rigidity Rigidity commented Apr 22, 2024

Here is a permalink to the chia-blockchain error codes I copied these from:

https://github.com/Chia-Network/chia-blockchain/blob/698455ee7ebe8bba16c2acadd0114de5788a9389/chia/util/errors.py

I used an LLM to make copying these over less tedious. So for that reason in addition to normal human error, careful review would be appreciated.

@Rigidity Rigidity requested a review from arvidn April 22, 2024 13:10
Copy link

coveralls-official bot commented Apr 22, 2024

Pull Request Test Coverage Report for Build 8786144322

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 33 of 153 (21.57%) changed or added relevant lines in 3 files are covered.
  • 11 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.6%) to 85.227%

Changes Missing Coverage Covered Lines Changed/Added Lines %
crates/chia-consensus/src/gen/messages.rs 1 2 50.0%
crates/chia-consensus/src/gen/validation_error.rs 11 130 8.46%
Files with Coverage Reduction New Missed Lines %
crates/chia-consensus/src/gen/validation_error.rs 4 25.64%
crates/chia-protocol/src/classgroup.rs 7 4.35%
Totals Coverage Status
Change from base Build 8762038099: -0.6%
Covered Lines: 11694
Relevant Lines: 13721

💛 - Coveralls

@Rigidity Rigidity merged commit 20cb4b8 into main Apr 23, 2024
64 checks passed
@Rigidity Rigidity deleted the error-codes branch April 23, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants