Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clean up merkle tests #462

Merged
merged 2 commits into from
Apr 16, 2024
Merged

clean up merkle tests #462

merged 2 commits into from
Apr 16, 2024

Conversation

arvidn
Copy link
Contributor

@arvidn arvidn commented Apr 16, 2024 •
edited
Loading

  • moves tests into a test module
  • defines constants with hex-literal instead of arrays of integers

This is best reviewed one commit at a time, ignoring whitespace.

@arvidn arvidn marked this pull request as ready for review April 16, 2024 12:07
@arvidn arvidn merged commit 490b468 into main Apr 16, 2024
63 checks passed
@arvidn arvidn deleted the merkle-tests branch April 16, 2024 12:24
@coveralls-official Coveralls Official
Copy link

Pull Request Test Coverage Report for Build 8705172526

Details

  • 290 of 290 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 85.387%
Totals Coverage Status
Change from base Build 8695103678: -0.1%
Covered Lines: 11219
Relevant Lines: 13139
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matt-o-how matt-o-how matt-o-how approved these changes

@Rigidity Rigidity Rigidity approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arvidn @Rigidity @matt-o-how